Bug 25419 - Install headers and .pc files when plugins are enabled
Summary: Install headers and .pc files when plugins are enabled
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-12-03 10:36 UTC by Will Thompson
Modified: 2009-12-03 13:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2009-12-03 10:36:16 UTC
My 'plugin-headers' branch installs a bunch of Wocky headers, plus the GabblePlugin and GabbleSidecar headers, when plugins are enabled. This means you can actually write plugins. :-)
Comment 1 Simon McVittie 2009-12-03 10:50:36 UTC
I'd prefer it if the headers were designed to be included like <gabble/sidecar.h>; you can either install them like $includedir/telepathy-1.0/gabble/gabble/sidecar.h or $includedir/telepathy-1.0/gabble/sidecar.h, but please put a parent of their directory on the -I path, rather than their directory itself.

You basically have to use one of these styles, if you want to avoid colliding header names:

* install to $FOO/foo/bar.h, use -I$FOO and consistently include <foo/bar.h> (telepathy-glib)
* call your headers foo-*.h (breaking tab completion), install to $FOO/foo-bar.h and use -I$FOO (NetworkManager)
* both of the above, redundantly (D-Bus, GLib)
Comment 2 Will Thompson 2009-12-03 11:35:47 UTC
Updated the branch accordingly.
Comment 3 Will Thompson 2009-12-03 13:16:19 UTC
Merged with review by Simon, thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.