Bug 25565 - geoclue needs support for libgps/gpsd >= 2.90
Summary: geoclue needs support for libgps/gpsd >= 2.90
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: Backends (obsolete) (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-12-10 08:13 UTC by Bernd Zeimetz
Modified: 2010-03-25 14:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Use pkgconfig to check for gpsd, require libgps 2.91 (1.17 KB, patch)
2009-12-17 03:01 UTC, Bernd Zeimetz
Details | Splinter Review
Update the gpsd provider to work with libgps 2.91 (2.62 KB, patch)
2009-12-17 03:01 UTC, Bernd Zeimetz
Details | Splinter Review

Description Bernd Zeimetz 2009-12-10 08:13:10 UTC
Since the latest gpsd/libgps version the API changed a lot and geoclue's gpsd provider needs to be fixed to reflect that. Also it should *DEFINITELY* stop trying to parse NMEA on its own. libgps comes with proper functions to retieve the data in sane ways.
Comment 1 Bernd Zeimetz 2009-12-17 03:01:11 UTC
Created attachment 32143 [details] [review]
Use pkgconfig to check for gpsd, require libgps 2.91
Comment 2 Bernd Zeimetz 2009-12-17 03:01:54 UTC
Created attachment 32144 [details] [review]
Update the gpsd provider to work with libgps 2.91
Comment 3 Bernd Zeimetz 2009-12-17 03:03:38 UTC
Please note that my patch is not properly tested, but I think it should work fine.

The patches are also available via git, see
http://git.recluse.de/?p=users/bzed/geoclue.git;a=summary
git://git.recluse.de/users/bzed/geoclue.git
and pull from the gpsd-fix branch.
Comment 4 Jussi Kukkonen [inactive] 2010-03-25 14:44:40 UTC
ok, I'm merging this. Better to have less tested gpsd provider than a non-working one. Thank you.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.