Bug 25728 - PATCH: Correction to drm_mm.c, part of kernel driver
Summary: PATCH: Correction to drm_mm.c, part of kernel driver
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/other (show other bugs)
Version: DRI git
Hardware: x86-64 (AMD64) Linux (All)
: medium critical
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-19 18:21 UTC by Bob Gleitsmann
Modified: 2009-12-27 12:44 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to correct memory block selection procedure (343 bytes, patch)
2009-12-19 18:21 UTC, Bob Gleitsmann
no flags Details | Splinter Review
Please ignore the patch named patchc. This one contains both corrections (728 bytes, patch)
2009-12-19 18:33 UTC, Bob Gleitsmann
no flags Details | Splinter Review

Description Bob Gleitsmann 2009-12-19 18:21:34 UTC
Created attachment 32201 [details] [review]
Patch to correct memory block selection procedure

This corrects the logic for selection of the best-fit memory block.

Best Wishes,

Bob Gleitsmann
Comment 1 Bob Gleitsmann 2009-12-19 18:33:22 UTC
Created attachment 32202 [details] [review]
Please ignore the patch named patchc. This one contains both corrections
Comment 2 Bob Gleitsmann 2009-12-27 12:16:52 UTC
The patch appears to fix kernel lockups when running 3D mesa demo apps. 
Comment 3 Maarten Maathuis 2009-12-27 12:41:28 UTC
I've added some CC's, this looks like a bug indeed.
Comment 4 Dave Airlie 2009-12-27 12:44:15 UTC
I've already posted this to dri-devel@lists.sf.net and it got acked.

e2108eb1f66d77b4af77caf282cab1d47e3f4831

in Linus kernel

commit e2108eb1f66d77b4af77caf282cab1d47e3f4831
Author: Bob Gleitsmann <rjgleits@bellsouth.net>
Date:   Mon Dec 21 13:52:09 2009 +1000

    drm/mm: fix logic for selection of best fit block
    
    This is from bug 25728.
    
    [airlied: I'm just forwarding the patch for review, Thomas, ickle?]
    
    Acked-by: Jerome Glisse <jglisse@redhat.com>
    Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.