Bug 25739 - Unbreak builds with incompatible libdrm_radeon
Summary: Unbreak builds with incompatible libdrm_radeon
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/R100 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-21 01:04 UTC by Fabio Pedretti
Modified: 2009-12-22 02:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch for master branch (807 bytes, patch)
2009-12-21 01:04 UTC, Fabio Pedretti
Details | Splinter Review
patch for mesa_7_7_branch branch (606 bytes, patch)
2009-12-21 01:07 UTC, Fabio Pedretti
Details | Splinter Review
patch for mesa_7_6_branch branch (607 bytes, patch)
2009-12-21 01:09 UTC, Fabio Pedretti
Details | Splinter Review

Description Fabio Pedretti 2009-12-21 01:04:03 UTC
Created attachment 32213 [details] [review]
patch for master branch

master branch require libdrm >= 2.4.17.
Comment 2 Fabio Pedretti 2009-12-21 01:09:02 UTC
Created attachment 32215 [details] [review]
patch for mesa_7_6_branch branch

7.6 should build with libdrm <= 2.4.16.
Comment 3 Dan Nicholson 2009-12-21 11:55:09 UTC
Can you use the LIBDRM_RADEON_REQUIRED in the 7.7 and 7.6 patches like you did for master?

Hmm, why does libdrm_radeon have a separate version number in the .pc file, and why isn't it being changed when the API changes? That would straighten this all out and be a real LIBDRM_RADEON_REQUIRED.
Comment 4 Alex Deucher 2009-12-21 12:17:56 UTC
libdrm_radeon is still experimental and hasn't been released yet.  It will be released when radeon KMS comes out of staging.
Comment 5 Dan Nicholson 2009-12-21 12:39:33 UTC
Right, I forgot that you only get to install it with --enable-radeon-experimental-api. In that case, I'm not really worried about the breakage. But it would be nice to keep libdrm_radeon.pc updated once you guys put it out in the wild.
Comment 6 Fabio Pedretti 2009-12-22 02:35:53 UTC
Alternatively the version of libdrm_radeon could be changed from 1.0.1 to @PACKAGE_VERSION@ like libdrm_intel and then check mesa for libdrm_radeon version rather than libdrm.

The API has however been updated for final 7.6.1 and 7.7 and all of them need now libdrm_radeon 2.4.17.

There are still two warnings that appears only when compiling without libdrm_radeon:

In file included from ../radeon/radeon_cs_drm.h:38,
                 from radeon_bocs_wrapper.h:29,
                 from radeon_cs_space_drm.c:31:
/usr/include/drm/radeon_drm.h:809:1: warning: "RADEON_TILING_SURFACE" redefined
In file included from radeon_cs_space_drm.c:31:
radeon_bocs_wrapper.h:23:1: warning: this is the location of the previous definition

In file included from ./../radeon/radeon_cs_drm.h:38,
                 from ./radeon_bocs_wrapper.h:29,
                 from radeon_bo.c:1:
/usr/include/drm/radeon_drm.h:809:1: warning: "RADEON_TILING_SURFACE" redefined
In file included from radeon_bo.c:1:
./radeon_bocs_wrapper.h:23:1: warning: this is the location of the previous definition


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.