Bug 25787 - [G45][KMS] Multi-function SDVO device: Secondary monitor TV-2 is blank black for dual display setup
Summary: [G45][KMS] Multi-function SDVO device: Secondary monitor TV-2 is blank black ...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: 7.4 (2008.09)
Hardware: Other Linux (All)
: medium normal
Assignee: ykzhao
QA Contact: Xorg Project Team
URL: https://bugzilla.novell.com/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 20:04 UTC by Vance
Modified: 2010-03-15 02:10 UTC (History)
9 users (show)

See Also:
i915 platform:
i915 features:


Attachments
xrandr with 1 display connected (449 bytes, text/plain)
2009-12-23 20:04 UTC, Vance
no flags Details
Xorg log when 1 display connected (23.92 KB, text/plain)
2009-12-23 20:05 UTC, Vance
no flags Details
xrandr output with 2 displays connetced (1.15 KB, text/plain)
2009-12-23 20:05 UTC, Vance
no flags Details
Xorg log with 2 displays attached (20.78 KB, text/plain)
2009-12-23 20:06 UTC, Vance
no flags Details
dmesg with drm.debug=0x06 option on 2.6.32 kernel (75.13 KB, text/plain)
2009-12-28 18:52 UTC, Vance
no flags Details
xrandr output with two displays connected on boot (817 bytes, text/plain)
2010-01-06 23:18 UTC, Vance
no flags Details
dmesg with drm.debug=0x06 option (178.29 KB, text/plain)
2010-01-06 23:19 UTC, Vance
no flags Details
try the debug patch which detects the S-video after SDVO-RGB (1.60 KB, patch)
2010-01-13 23:54 UTC, ykzhao
no flags Details | Splinter Review
dmesg (240.53 KB, text/plain)
2010-01-14 20:16 UTC, Vance
no flags Details
Detet SDVO-VGA before SDVO-TV for multi-function SDVO card (2.13 KB, patch)
2010-01-27 19:40 UTC, ykzhao
no flags Details | Splinter Review
vbios dump (64.00 KB, application/octet-stream)
2010-02-01 22:23 UTC, Vance
no flags Details
dmidecode (24.45 KB, text/plain)
2010-02-01 22:24 UTC, Vance
no flags Details
Use the dmi quirk to initialze some SDVO card as SDVO-VGA (2.11 KB, patch)
2010-02-02 23:29 UTC, ykzhao
no flags Details | Splinter Review
Use the dmi quirk to initialze some SDVO card as SDVO-VGA (1.62 KB, patch)
2010-02-03 00:51 UTC, ykzhao
no flags Details | Splinter Review
Xorg.log (29.28 KB, text/plain)
2010-02-03 19:12 UTC, Vance
no flags Details
xorg.conf (5.47 KB, text/plain)
2010-02-03 19:13 UTC, Vance
no flags Details
dmesg.log with drm.debug (81.02 KB, text/plain)
2010-02-03 19:32 UTC, Vance
no flags Details
redefine the clonemaks for SDVO-VGA and VGA (1.97 KB, patch)
2010-02-03 23:36 UTC, ykzhao
no flags Details | Splinter Review
intel_sdvo.c.rej (1.20 KB, text/plain)
2010-02-04 00:23 UTC, Vance
no flags Details
redefine the clonemaks for SDVO-VGA and VGA (2.01 KB, patch)
2010-02-04 18:21 UTC, ykzhao
no flags Details | Splinter Review
xrandr (7.12 KB, text/plain)
2010-02-05 01:33 UTC, Vance
no flags Details
dmesg (101.43 KB, text/plain)
2010-02-05 01:36 UTC, Vance
no flags Details
Add some debug info related with the crtc/output (1.77 KB, patch)
2010-02-05 18:14 UTC, ykzhao
no flags Details | Splinter Review
dmesg log (85.78 KB, text/plain)
2010-02-08 03:24 UTC, Vance
no flags Details
intel encoder/connector rework for multifunction SDVO support (197.16 KB, patch)
2010-03-02 01:12 UTC, Wang Zhenyu
no flags Details | Splinter Review
xrandr output (1020 bytes, text/plain)
2010-03-02 18:58 UTC, Vance
no flags Details
Xorg.0.log (23.09 KB, text/plain)
2010-03-02 18:59 UTC, Vance
no flags Details
dmesg (209.76 KB, text/plain)
2010-03-02 19:00 UTC, Vance
no flags Details

Description Vance 2009-12-23 20:04:05 UTC
Created attachment 32273 [details]
xrandr with 1 display connected

Intel G45 requires patch to change detection of secondary video output from TV to VGA for dual display to function.

The following three patches are required to fix this issue.

http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=6ba148bbd78783f59eed3d898638c39b950dcd89

http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=51b87b9913ba164d4d5de79e558233915b37a0a5

http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=3da549f5b350dd42516e5cb3576f7fefe012d95e

Tested the intel driver version 2.9.99 on a 2.6.32 kernel with KMS enabled and the secondary output is still detected as TV-1.
Comment 1 Vance 2009-12-23 20:05:19 UTC
Created attachment 32274 [details]
Xorg log when 1 display connected
Comment 2 Vance 2009-12-23 20:05:56 UTC
Created attachment 32275 [details]
xrandr output with 2 displays connetced
Comment 3 Vance 2009-12-23 20:06:35 UTC
Created attachment 32276 [details]
Xorg log with 2 displays attached
Comment 4 Vance 2009-12-23 20:14:29 UTC
xorg-server version used was 1.6.5.
Comment 5 ykzhao 2009-12-23 21:27:28 UTC
Will you please add the boot option of "drm.debug=0x06" on the 2.6.32.2 kernel and attach the output of dmesg?

thanks.
Comment 6 Stefan Dirsch 2009-12-24 00:32:47 UTC
ykzhao, SLE11-SP1 Beta1 has still Kernel 2.6.32 (not sure if SLE11-SP1 will ship Kernel 2.6.32.2). I've seen the following commits to drivers/gpu/drm/i915 between 2.6.32.1 and 2.6.32.2 (no commits below this directory between 2.6.32 and 2.6.32.1). 

 drm/i915: Set the error code after failing to insert new offset into mm ht.
 drm/i915: Add the missing clonemask for display port on Ironlake
 drm/i915: Fix sync to vblank when VGA output is turned off
 drm/i915: Avoid NULL dereference with component_only tv_modes
 drm/i915: PineView only has LVDS and CRT ports
 drm/i915: Fix LVDS stability issue on Ironlake

Do you believe any of these commits addresses that issue? Otherwise I suggest to go ahead testing with 2.6.32 kernel of SLE11-SP1.
Comment 7 Michael Fu 2009-12-24 17:10:36 UTC
2.6.32 kernel is fine too, please attach the dmesg with drm.debug=0x06 kernel parameter added. thanks.
Comment 8 Vance 2009-12-28 18:52:16 UTC
Created attachment 32339 [details]
dmesg with drm.debug=0x06 option on 2.6.32 kernel
Comment 9 Vance 2010-01-03 22:46:03 UTC
Hi, any updates on this? Let me know if more information is required.
Comment 10 ykzhao 2010-01-06 07:20:29 UTC
(In reply to comment #6)
> ykzhao, SLE11-SP1 Beta1 has still Kernel 2.6.32 (not sure if SLE11-SP1 will
> ship Kernel 2.6.32.2). I've seen the following commits to drivers/gpu/drm/i915
> between 2.6.32.1 and 2.6.32.2 (no commits below this directory between 2.6.32
> and 2.6.32.1). 
>  drm/i915: Set the error code after failing to insert new offset into mm ht.
>  drm/i915: Add the missing clonemask for display port on Ironlake
>  drm/i915: Fix sync to vblank when VGA output is turned off
>  drm/i915: Avoid NULL dereference with component_only tv_modes
>  drm/i915: PineView only has LVDS and CRT ports
>  drm/i915: Fix LVDS stability issue on Ironlake
> Do you believe any of these commits addresses that issue? Otherwise I suggest
> to go ahead testing with 2.6.32 kernel of SLE11-SP1.

Hi, Stefan
    The issue on Vance's box is not related with the above commit. And there is no difference even when the above commit is applied.

Anyway, thanks for pointing out the difference between 2.6.32.1 and 2.6.32.2.

thanks.
Comment 11 ykzhao 2010-01-06 07:30:13 UTC
(In reply to comment #8)
> Created an attachment (id=32339) [details]
> dmesg with drm.debug=0x06 option on 2.6.32 kernel
Hi, Vance
    Thanks for the testing. From the dmesg log it seems that it reports the following info when detecting whether the external monitor is connected with the SDVO card.
   >[drm:intel_sdvo_detect], SDVO response 0 0
   In such case it will be thought that no external monitor is connected.
  
   Will you please double check whether the external monitor is connected?

   Can you try the 2.6.33-rc3 kernel and attach the output of dmesg after the system is booted? (The boot option of "drm.debug=0x06" is required. BTW: the external monitor had better be connected before booting).

Thanks.


Comment 12 Vance 2010-01-06 23:18:10 UTC
Created attachment 32490 [details]
xrandr output with two displays connected on boot

Hi, I have compiled and installed the 2.6.33rc3 kernel and extracted the xorg log with the drm.debug=0x06 kernel option and xrandr output with two displays connected to the video adapter. Both displays were already connected on boot.

Seems like xrandr is still detecting only one VGA1 output when both displays are connected. When only one display is connected on boot, there will be a VGA1 and a TV1 output listed.
Comment 13 Vance 2010-01-06 23:19:14 UTC
Created attachment 32491 [details]
dmesg with drm.debug=0x06 option
Comment 14 Vance 2010-01-13 02:33:35 UTC
Is the provided information sufficient?
Comment 15 ykzhao 2010-01-13 23:54:36 UTC
Created attachment 32620 [details] [review]
try the debug patch which detects the S-video after SDVO-RGB

Sorry that I forget to attach the patch. 

Will you please try the debug patch on 2.6.33-rc3 kernel and attach the output of dmesg? (the boot option of "drm.debug=0x06" is required).

Thanks.
    Yakui.
Comment 16 Vance 2010-01-14 20:16:01 UTC
Created attachment 32649 [details]
dmesg

Hi, I've compiled the 2.6.33-rc3-0.6.8 kernel after applying the patch and now xrandr is able to detect correctly the second connected display at VGA2. Dual display modes are also found to be working. This is great. Will the patch be applicable to earlier versions of the kernels like 2.6.32? Thanks.
Comment 17 Stefan Dirsch 2010-01-19 17:52:43 UTC
(In reply to comment #15)
> Created an attachment (id=32620) [details]
> try the debug patch which detects the S-video after SDVO-RGB

ykzhao, are you planning to submit this patch also to Linus kernel tree? gregkh is
asking since usually never accepts a patch for the SUSE kernel, which isn't
scheduled to upstream kernel as well.
Comment 18 Guek Wu Neo 2010-01-20 18:08:08 UTC
Intel Michael/YZ

we look forward to you respond  to the question posted in comment#16.
Will the patch be applicable to earlier versions of the kernels like 2.6.32?

If yes, could you submit it to upstream? Novell needs to pick up from there for it to be included in SUSE kernel release.
Comment 19 ykzhao 2010-01-20 23:23:55 UTC
(In reply to comment #18)
> Intel Michael/YZ
> 
> we look forward to you respond  to the question posted in comment#16.
> Will the patch be applicable to earlier versions of the kernels like 2.6.32?
> 
> If yes, could you submit it to upstream? Novell needs to pick up from there for
> it to be included in SUSE kernel release.

Now I am trying to find the proper solution for this issue. After this is finished, I will attach it.

thanks.
> 

Comment 20 Guek Wu Neo 2010-01-22 02:26:14 UTC
Thank you YaKui for you status update. Roughly when can you finish and attached it to upstream?
Comment 21 Vance 2010-01-24 23:51:51 UTC
Hi, any further developments? Thanks.
Comment 22 Michael Fu 2010-01-25 15:21:51 UTC
official fix will be sent out in this week. thanks.
Comment 23 ykzhao 2010-01-27 19:40:58 UTC
Created attachment 32863 [details] [review]
Detet SDVO-VGA before SDVO-TV for multi-function SDVO card

This is the workaround patch and it can fix this issue on such multi-function SDVO card.

Thanks.
Comment 24 Vance 2010-01-28 22:13:37 UTC
Thanks for the updated patch, I have compiled it on a 2.6.32 kernel and dual display is working properly. Have this patch been committed, and if not when do you intent to commit it? Thanks.
Comment 25 ykzhao 2010-01-30 05:20:08 UTC
(In reply to comment #24)
> Thanks for the updated patch, I have compiled it on a 2.6.32 kernel and dual
> display is working properly. Have this patch been committed, and if not when do
> you intent to commit it? Thanks.
The patch is already sent to intel-gfx mailing list. And we will wait for some time before it can be commited.

Will you please attach the vbios.dump on your box? The vbios.dump can be obtained by using the following command:
> echo 1 > /sys/devices/pci0000:00/0000:00:02.0/rom
> cat /sys/devices/pci0000:00/0000:00:02.0/rom >vbios.dump
> echo 0 > /sys/devices/pci0000:00/0000:00:02.0/rom

thanks.
Comment 26 ykzhao 2010-02-01 19:54:07 UTC
(In reply to comment #24)
> Thanks for the updated patch, I have compiled it on a 2.6.32 kernel and dual
> display is working properly. Have this patch been committed, and if not when do
> you intent to commit it? Thanks.
> 

Will you please also attach the output of dmidecode on your box?

thanks.
   Yakui

Comment 27 Vance 2010-02-01 22:23:28 UTC
Created attachment 32988 [details]
vbios dump
Comment 28 Vance 2010-02-01 22:24:09 UTC
Created attachment 32989 [details]
dmidecode

The logs as you requested.
Comment 29 Michael Fu 2010-02-02 02:20:51 UTC
Vance, is the second VGA connector provide by a pluggable card or built on the motherboard directly? thanks.
Comment 30 Vance 2010-02-02 21:49:39 UTC
Hi Michael, the secondary display port is built on the motherboard.
Comment 31 ykzhao 2010-02-02 23:29:03 UTC
Created attachment 33021 [details] [review]
Use the dmi quirk to initialze some SDVO card as SDVO-VGA

Thanks for the confirmation that it is built on the motherboard.


Will you please try the attached patch and see whether it can work for you?

Thanks.
   Yakui
Comment 32 Vance 2010-02-02 23:59:54 UTC
Hi, this is to be applied on the original intel_sdvo.c and not the one patched with the previous patch right? Thanks.
Comment 33 ykzhao 2010-02-03 00:51:31 UTC
Created attachment 33022 [details] [review]
Use the dmi quirk to initialze some SDVO card as SDVO-VGA

Will you please try the updated patch and see whether the issue can be fixed?

thanks
Comment 34 Michael Fu 2010-02-03 01:45:34 UTC
(In reply to comment #32)
> Hi, this is to be applied on the original intel_sdvo.c and not the one patched
> with the previous patch right? Thanks.
> 

yes. thanks.
Comment 35 Vance 2010-02-03 19:06:29 UTC
Hi, I tried out this patch. Something weird happened though, the secondary port is still detected correctly as VGA2 but using the same xorg configuration I used previously, I couldn't get extended desktop to work. The secondary display is blank and the primary display is only running a single normal desktop. I'm attaching a few logs here so you can see if anything went wrong.
Comment 36 Vance 2010-02-03 19:12:33 UTC
Created attachment 33046 [details]
Xorg.log
Comment 37 Vance 2010-02-03 19:13:06 UTC
Created attachment 33047 [details]
xorg.conf
Comment 38 Vance 2010-02-03 19:32:10 UTC
Created attachment 33048 [details]
dmesg.log with drm.debug
Comment 39 Michael Fu 2010-02-03 19:59:26 UTC
(In reply to comment #35)
> Hi, I tried out this patch. Something weird happened though, the secondary port
> is still detected correctly as VGA2 but using the same xorg configuration I
> used previously, I couldn't get extended desktop to work. The secondary display
> is blank and the primary display is only running a single normal desktop. I'm
> attaching a few logs here so you can see if anything went wrong.
> 

vance, if without the xorg.conf at all, can you get something on the second display by default when the system boot up? thanks.
Comment 40 Vance 2010-02-03 21:59:26 UTC
After removing the xorg.conf, there is still nothing on the secondary display. I tried using xrandr to set the extended mode but nothing happened.
Comment 41 ykzhao 2010-02-03 22:18:42 UTC
(In reply to comment #38)
> Created an attachment (id=33048) [details]
> dmesg.log with drm.debug
> 
From the dmesg log in comment #37 it seems that the driver doesn't set the corresponding mode for VGA-2 output device.(For the VGA-1 we can find the following info in dmesg and we can know that it sets the correct mode. But we can't find the corresponding info for VGA-2).
    >[drm:drm_crtc_helper_set_config], setting connector 5 crtc
  

Will you please confirm whether the VGA-2 can work by using following command after X is started?
   > xrandr --output VGA-2 --mode 1024x768

It will be great if you can do the test on 2.6.33-rcX kernel.(Of course the patch in comment #33 is still required).

Thanks.
   Yakui



Comment 42 Michael Fu 2010-02-03 22:55:25 UTC
(In reply to comment #41)
> (In reply to comment #38)
> > Created an attachment (id=33048) [details] [details]
> > dmesg.log with drm.debug
> > 
> From the dmesg log in comment #37 it seems that the driver doesn't set the
> corresponding mode for VGA-2 output device.(For the VGA-1 we can find the
> following info in dmesg and we can know that it sets the correct mode. But we
> can't find the corresponding info for VGA-2).
>     >[drm:drm_crtc_helper_set_config], setting connector 5 crtc
> 
> 
> Will you please confirm whether the VGA-2 can work by using following command
> after X is started?
>    > xrandr --output VGA-2 --mode 1024x768
> 

do you mean VGA2 instead of VGA-2?

> It will be great if you can do the test on 2.6.33-rcX kernel.(Of course the
> patch in comment #33 is still required).
> 
> Thanks.
>    Yakui
> 

Comment 43 ykzhao 2010-02-03 23:00:37 UTC
Yes. It should be VGA2 instead of VGA-2. Sorry that I mix the output name with that in kernel driver.

thanks.
> 

Comment 44 ykzhao 2010-02-03 23:36:52 UTC
Created attachment 33052 [details] [review]
redefine the clonemaks for SDVO-VGA and VGA

Will you please also try the attached patch and see whether it is helpful?

The patch in comment #33 is still required.

Thanks.
    Yakui
Comment 45 Vance 2010-02-04 00:22:44 UTC
Hi, thanks for the updates. I tried the patch from comment34 but I got the following error:

patching file drivers/gpu/drm/i915/intel_crt.c
Hunk #1 succeeded at 537 (offset -3 lines).
patching file drivers/gpu/drm/i915/intel_sdvo.c
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 2357.
1 out of 1 hunk FAILED -- saving rejects to file drivers/gpu/drm/i915/intel_sdvo.c.rej
/match>

The same error was observed on both the 2.6.33-rc3 and 2.6.22 kernels. This patch was applied after applying the patch from comment 33.
Comment 46 Vance 2010-02-04 00:23:21 UTC
Created attachment 33053 [details]
intel_sdvo.c.rej
Comment 47 Vance 2010-02-04 01:35:12 UTC
Without the latest patch, running xrandr --output VGA2 --mode 1024x768 returns xrandr: cannot find crtc for output VGA2
Comment 48 ykzhao 2010-02-04 16:52:28 UTC
(In reply to comment #47)
> Without the latest patch, running xrandr --output VGA2 --mode 1024x768 returns
> xrandr: cannot find crtc for output VGA2
> 
Can you attach the output of dmesg on 2.6.33-rc3 kernel after running the following command? (the boot option of "drm.debug=0x04" is added).
   a. xrandr -q --verbose
   b. xrandr --output VGA2 --mode 1024x768 --crtc 1

The output of xrandr -q --verbose is also needed.

Thanks.
   Yakui

Comment 49 ykzhao 2010-02-04 18:21:32 UTC
Created attachment 33085 [details] [review]
redefine the clonemaks for SDVO-VGA and VGA

I update the patch on 2.6.33-rc3.
Please try it.

thanks.
Comment 50 Vance 2010-02-05 01:31:34 UTC
Hi Yakui, I used your patch on a 2.6.33-rc3 kernel after applying the patch in comment 33. The dual outputs are detected correctly and the extended desktop is displayed properly as well. I'm attaching the dmesg and xrandr logs for you to verify.
Comment 51 Vance 2010-02-05 01:33:35 UTC
Created attachment 33089 [details]
xrandr
Comment 52 Vance 2010-02-05 01:36:11 UTC
Created attachment 33090 [details]
dmesg
Comment 53 Michael Fu 2010-02-05 01:41:01 UTC
(In reply to comment #50)
> Hi Yakui, I used your patch on a 2.6.33-rc3 kernel after applying the patch in
> comment 33. The dual outputs are detected correctly and the extended desktop is
> displayed properly as well. I'm attaching the dmesg and xrandr logs for you to
> verify.
> 

so, even without patch in comment# 49, right? Previously, you tested the same patch in comment# 33 in .32 kernel, right? So looks like there is something changed between .32 and .33 that makes the patch didn't work in .32... 

thanks for the testing, Vance!
Comment 54 ykzhao 2010-02-05 18:14:28 UTC
Created attachment 33099 [details] [review]
Add some debug info related with the crtc/output

Hi, Vance
    Thanks for the testing. I agree with what Michael said in comment #53. The SDVO-card can work on 2.6.33-rc3 kernel. But it can't work on 32.kernel. 

    Will you please try the attached patch on 32 kernel and attach the output of dmesg, xrandr -q --verbose? (Please still add the boot option of "drm.debug=0x04". And the patch in comment #33 is still needed).
    
Thanks.
Comment 55 Vance 2010-02-07 18:55:44 UTC
Hi Michael and Yakui, my results in comment#50 came from applying both the patches from comment #33 and #49 to the 2.6.33 kernel. I have not tried both patches on a 32 kernel. I'll go ahead and test both patches on the 32 kernel and report back here.
Comment 56 Michael Fu 2010-02-07 19:38:10 UTC
(In reply to comment #55)
> Hi Michael and Yakui, my results in comment#50 came from applying both the
> patches from comment #33 and #49 to the 2.6.33 kernel. I have not tried both
> patches on a 32 kernel. I'll go ahead and test both patches on the 32 kernel
> and report back here.
> 

Vance, could you pls confirm _without_ patch in comment# 49 but just the patch in comment# 33, will it work?

In comment# 24, you said applying the patch in comment# 23 on 2.6.32 kernel, and it works.

In comment# 38, you attached a dmesg which is 2.6.32.5 with only patch in comment# 33 applied. it breaks.


technically, patch in comment# 23 and comment# 33 really makes no difference but just skip the SDVO-SVIDEO detection. so we are wondering why patch in comment# 33 doesn't work in .32 kernel while patch in comment# 23 does... 

yakui's latest debug patch in comment# 54 is just prink, so please apply it in your test and give us dmesg.

I'll appreciated if you can state exactly what patche(s) are applied on which version of kernel in your later test, it'll help us figure this out sooner. 

thanks!
Comment 57 ykzhao 2010-02-07 21:01:26 UTC
HI, Vance
    Will you please do the test as suggested in comment #56?
   
    Please apply the patch in comment #33 and #54 on .32 kernel and attach the output of dmesg.

    Please only apply the patch in comment #33 on 2.6.33-rc3 kernel and see whether the second VGA can work. Please attach the output of dmesg.

BTW: The boot option of "drm.debug=0x04" had better be added in your test.

thanks.
Comment 58 Vance 2010-02-08 03:24:26 UTC
Created attachment 33151 [details]
dmesg log

I have retested using only the patch in comment 33 on a 2.6.32 kernel and it is working fine in extended dual display mode. The secondary output is also correctly detected. Either I had compiled the kernel wrongly the first time round or I had used the patch in comment 31 instead. Please help to commit this patch upstream as soon as you can. Thanks for working so closely on resolving this issue.
Comment 59 Vance 2010-02-24 19:27:09 UTC
Hi Yakui, any updates on whether the upstream kernel has accepted this patch? Thanks.
Comment 60 Eric Anholt 2010-02-26 11:59:18 UTC
Sorry for the delay, Vance.  Last word I had from Yakui on this patch was "This patch still has some problems. Please ignore this patch" back on the 8th.  However, since it's working for you, and the risk to others is low, I've cleaned it up and pushed it for drm-intel-next, which means it should land in a 2.6.33 update shortly.

commit bfee3e822746f26395a10602a3a7c3baac107972
Author: Zhao Yakui <yakui.zhao@intel.com>
Date:   Mon Feb 8 21:35:12 2010 +0800

    drm/i915: Use a dmi quirk to skip a broken SDVO TV output.
    
    This IBM system has a multi-function SDVO card that reports both VGA
    and TV, but the system has no TV connector.  The TV connector always
    reported as connected, which would lead to poor modesetting choices.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=25787
    
    Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
    Tested-by: Vance <liangghv@sg.ibm.com>
    Cc: stable@kernel.org
    Signed-off-by: Eric Anholt <eric@anholt.net>
Comment 61 Vance 2010-03-01 03:06:58 UTC
Hi, I have another machine using the 915GM video chipset that appears to have similar secondary output detection issue as raised in this thread. The secondary output is detected as a TV output instead of a VGA output. I tried to use the patch provided here but it looks like the patch is targeted specifically at the G45 chipset and on the 4800-784 machine. Should I open a separate bug for this issue? Thanks.
Comment 62 Wang Zhenyu 2010-03-02 01:12:22 UTC
Created attachment 33682 [details] [review]
intel encoder/connector rework for multifunction SDVO support

Vance, could you help to test if this patch works for you? yeah, it's large. And if you have problem to apply it onto previous Yakui's quirk patch, you may first revert that patch as well.

thanks.
Comment 63 Vance 2010-03-02 03:32:42 UTC
(In reply to comment #62)
> Created an attachment (id=33682) [details]
> intel encoder/connector rework for multifunction SDVO support
> 
> Vance, could you help to test if this patch works for you? yeah, it's large.
> And if you have problem to apply it onto previous Yakui's quirk patch, you may
> first revert that patch as well.
> 
> thanks.
> 

Hi Zhenyu, does this latest patch require Ya kui's patch to resolve this issue? I tried patching it on a 2.6.32 kernel but there are a number of failed chunks even without Ya Kui's patch. I will try again with the latest 33 kernel. Also with regards to my previous question where I have another chipset facing what I believe is a similar issue, will this patch work for that chipset as well? Thanks.
Comment 64 Michael Fu 2010-03-02 04:47:16 UTC
1. no need for yakui's quirk patch
2. yes, it should fix the issue on your other platform as well, if everything work as expected.
Comment 65 Vance 2010-03-02 18:58:12 UTC
Created attachment 33704 [details]
xrandr output

Hi, I've given the patch a try on a 2.6.33 kernel but it seems like the secondary VGA port is detected as not connected. I'll be attaching the relevant logs here. Is this latest patch going to replace the one proposed by Ya Kui that has already been committed to the kernel tree?
Comment 66 Vance 2010-03-02 18:59:27 UTC
Created attachment 33705 [details]
Xorg.0.log
Comment 67 Vance 2010-03-02 19:00:47 UTC
Created attachment 33706 [details]
dmesg
Comment 68 Vance 2010-03-07 19:46:27 UTC
Hi, any updates on this? Thanks.
Comment 69 ykzhao 2010-03-07 21:28:55 UTC
(In reply to comment #68)
> Hi, any updates on this? Thanks.

Will you please try the updated patch in the following and see whether it works for you?
   >http://lists.freedesktop.org/archives/intel-gfx/2010-March/006063.html

thanks.
> 

Comment 70 Vance 2010-03-09 02:45:43 UTC
Hi Yakui, I tested the latest patch from http://lists.freedesktop.org/archives/intel-gfx/2010-March/006063.html on the 2.6.33 kernel and the secondary VGA output is detected and working correctly. Are there any logs you like to see?
Comment 71 Vance 2010-03-14 23:41:39 UTC
Hi Yakui, as this patch http://lists.freedesktop.org/archives/intel-gfx/2010-March/006063.html been successfully committed into the upstream kernel? Also has the previous patch been reverted up stream as well? Looking at this site( http://git.kernel.org/?p=linux/kernel/git/anholt/drm-intel.git;a=commit;h=6070a4a928f8c92b9fae7d6717ebbb05f425d6b2), I can't see whether it's been acknowledged. Thanks.
Comment 72 ykzhao 2010-03-15 00:44:13 UTC
(In reply to comment #71)
> Hi Yakui, as this patch
> http://lists.freedesktop.org/archives/intel-gfx/2010-March/006063.html been
> successfully committed into the upstream kernel? Also has the previous patch
> been reverted up stream as well? Looking at this site(
> http://git.kernel.org/?p=linux/kernel/git/anholt/drm-intel.git;a=commit;h=6070a4a928f8c92b9fae7d6717ebbb05f425d6b2),
> I can't see whether it's been acknowledged. Thanks.

The patch is not commited to the upstream kernel. And the commit(6070a4a928f8c92b9fae7d6717ebbb05f425d6b2) is not reverted, either.

Thanks.
> 

Comment 73 Vance 2010-03-15 02:10:49 UTC
Hi Yakui, thanks for the reply. If this is the case, I need to know which patch is the intended fix that will be submitted upstream to fix this issue. Novell is waiting to integrate this patch into their kernel but they will only do it once it's been committed and accepted upstream. We have a narrow window for them to include this fix into their kernel so appreciate if you could help us clarify and/or expedite the process. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.