Bug 26155 - Set fatal criticals
Summary: Set fatal criticals
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-21 04:21 UTC by Simon McVittie
Modified: 2010-12-01 02:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-01-21 04:21:36 UTC 
telepathy-glib used to make critical warnings fatal for CMs (Bug #14603). Versions >= 0.9.3 will not do this, so if we want the code-quality benefits of treating these warnings as fatal, we should enable that specifically in each CM where it's relevant.

In Haze's case, we need to be careful about what's critical and what isn't, since some of libpurple is apparently quite critical-happy.

(WONTFIX is an acceptable resolution for this bug if that's the maintainers' considered opinion.)
Comment 1 Simon McVittie 2010-11-30 10:12:26 UTC 
I fixed this while debugging the TpBaseContactList branch of Haze.
Comment 2 Simon McVittie 2010-12-01 02:47:39 UTC 
r+ from Jonny on IRC, fixed in git for 0.5.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.