Bug 26271 - Crashes if you send it disco requests with no id=''
Summary: Crashes if you send it disco requests with no id=''
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-27 06:58 UTC by Will Thompson
Modified: 2010-01-27 07:07 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2010-01-27 06:58:53 UTC 
It's illegal to send <iq/> stanzas without an id='' (per the first rule of IQ Semantics in XMPP Core <http://xmpp.org/rfcs/rfc3920.html#stanzas-semantics-iq>), but neither ejabberd nor Loudmouth filters them out before they reach Gabble. If passed an IQ with no id='', lm_iq_message_make_result() returns NULL; connection_iq_disco_cb() assumed that it returned a valid message, and hence crashes.

Patch to follow...
Comment 1 Will Thompson 2010-01-27 07:01:28 UTC 
The patch at http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=commitdiff;h=refs/heads/crash-on-disco-without-id is against 0.8, but applies cleanly to 0.9. While Wocky shouldn't let such IQs through — I'm off to file a bug — I think it's worth applying the patch to 0.9 too.
Comment 2 Will Thompson 2010-01-27 07:07:03 UTC 
Merged to 0.8 and master (as a55f9ed and d4ef47a respectively), will be in 0.8.10 and 0.9.4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.