Bug 26652 - RemoveMembers raises NotImplemented with 1-1 chat
Summary: RemoveMembers raises NotImplemented with 1-1 chat
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: butterfly (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ol...
Whiteboard: review+
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 08:14 UTC by Guillaume Desmottes
Modified: 2010-03-09 08:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2010-02-19 08:14:58 UTC
- Get empathy master (to have https://bugzilla.gnome.org/show_bug.cgi?id=610461 fixed)
- Open a chat with a MSN contact and say something
- Close the chat window
- Empathy calls RemoveMembers on the self-handle but fails because of a NotImplemented error.


(empathy:28206): empathy-DEBUG: leave_remove_members_cb: RemoveMembers failed (org.freedesktop.DBus.Python.NotImplementedError: Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/usr/lib/python2.6/dist-packages/telepathy/_generated/Channel_Interface_Group.py", line 232, in RemoveMembers
    raise NotImplementedError
NotImplementedError
); closing the channel
Comment 1 Jonny Lamb 2010-03-08 04:51:25 UTC
class ButterflyTextChannel(
        telepathy.server.ChannelTypeText,
        telepathy.server.ChannelInterfaceGroup,
        telepathy.server.ChannelInterfaceChatState,
        papyon.event.ContactEventInterface,
        papyon.event.ConversationEventInterface):

We subclass ChannelInterfaceGroup, but don't implement any of its methods.
Comment 2 Olivier Le Thanh Duong 2010-03-09 05:45:35 UTC
I implemented the method in this branch
http://git.collabora.co.uk/?p=user/olethanh/telepathy-butterfly.git;a=shortlog;h=refs/heads/remove_members
Comment 3 Jonny Lamb 2010-03-09 07:48:28 UTC
(In reply to comment #2)
> I implemented the method in this branch

Yeah the patch looks fine.

I was going to say wait until I've merged my conference changes, but if you want to do a release soonish, then go ahead. Perhaps this won't actually affect me at all, actually.
Comment 4 Olivier Le Thanh Duong 2010-03-09 08:45:42 UTC
Merged thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.