Bug 26694 - patch: omit writing of embedded fonts into tempary files (cairo)
Summary: patch: omit writing of embedded fonts into tempary files (cairo)
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: cairo backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-22 04:14 UTC by Jan Kümmel
Modified: 2010-02-27 09:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch: Omit writing of embedded fonts into tempary files (cairo) (10.45 KB, patch)
2010-02-22 04:14 UTC, Jan Kümmel
Details | Splinter Review

Description Jan Kümmel 2010-02-22 04:14:35 UTC
Created attachment 33489 [details] [review]
patch: Omit writing of embedded fonts into tempary files (cairo)

This patch loads embedded fonts directly from memory instead of writing them to a temporary file first. This should make it faster and fixes a race condition which occurs under win32 when more than one process using poppler uses the same temp file.

Furthermore, two printfs have been converted to fprintf(stderr,...) since writing error messages to stdout corrupts output from converters writing to stdout.
Comment 1 Carlos Garcia Campos 2010-02-27 09:02:39 UTC
Applied to git master. Thank you very much. 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.