Bug 26881 - Remove the usage of QString::fromAscii
Summary: Remove the usage of QString::fromAscii
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-04 05:54 UTC by Andre Moreira Magalhaes
Modified: 2010-03-18 09:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Andre Moreira Magalhaes 2010-03-04 05:54:51 UTC 
Avoid usage of QString::fromAscii if not really necessary
Comment 1 Will Thompson 2010-03-17 02:46:39 UTC 
(In reply to comment #0)
> Avoid usage of QString::fromAscii if not really necessary

Are there cases where it is really necessary?
Comment 2 Simon McVittie 2010-03-17 05:48:00 UTC 
Patch looks good. Is it sufficient to make telepathy-qt4 build when using QT_DISABLE_ASCII_CAST or whatever it's called? If not, please make that happen too :-)
Comment 3 Andre Moreira Magalhaes 2010-03-17 07:22:06 UTC 
(In reply to comment #2)
> Patch looks good. Is it sufficient to make telepathy-qt4 build when using
> QT_DISABLE_ASCII_CAST or whatever it's called? If not, please make that happen
> too :-)
> 

Bug #27125 makes TelepathyQt4 builds with QT_NO_CAST_FROM_ASCII
Comment 4 Andre Moreira Magalhaes 2010-03-17 07:22:48 UTC 
(In reply to comment #1)
> (In reply to comment #0)
> > Avoid usage of QString::fromAscii if not really necessary
> 
> Are there cases where it is really necessary?
> 
No, there is not
Comment 5 Andre Moreira Magalhaes 2010-03-18 09:15:57 UTC 
Fixed upstream. It will be in next version 0.3.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.