RADEON_DEBUG=fall has shown me this while running wine 1.1.40, glsl disabled, orm=backbuffer: Falling back to sw for ReadPixels (format GL_BGRA, type GL_UNSIGNED_INT_8_8_8_8_REV) Using latest mesa git. glxinfo|grep OpenGL OpenGL vendor string: Advanced Micro Devices, Inc. OpenGL renderer string: Mesa DRI R600 (RV730 9498) 20090101 TCL DRI2 OpenGL version string: 2.0 Mesa 7.9-devel OpenGL shading language version string: 1.10
This patch appears to solve this case, and piglit doesn't complain. The switch should probably contain more formats though. diff --git a/src/mesa/drivers/dri/radeon/radeon_pixel_read.c b/src/mesa/drivers/dri/radeon/radeon_pixel_read.c index b180c1d..943c034 100644 --- a/src/mesa/drivers/dri/radeon/radeon_pixel_read.c +++ b/src/mesa/drivers/dri/radeon/radeon_pixel_read.c @@ -68,6 +68,12 @@ static gl_format gl_format_and_type_to_mesa_format(GLenum format, GLenum type) return MESA_FORMAT_ARGB8888_REV; } break; + case GL_BGRA: + switch (type) { + case GL_UNSIGNED_INT_8_8_8_8_REV: + return MESA_FORMAT_ARGB8888; + } + break; } return MESA_FORMAT_NONE;
What app are you hitting this fallback with?
(In reply to comment #2) > What app are you hitting this fallback with? > World of Warcraft running under wine 1.1.40, glsl disabled, orm=backbuffer.
I've pushed extended version of your patch that handles also other formats.
(In reply to comment #4) > I've pushed extended version of your patch that handles also other formats. > Thanks, it works!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.