Bug 27122 - Allows starting a text chat to an invalid contact
Summary: Allows starting a text chat to an invalid contact
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: butterfly (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-03-16 19:25 UTC by Jonny Lamb
Modified: 2010-03-31 04:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Jonny Lamb 2010-03-16 19:25:54 UTC 
The commit says it all. Trivial.
Comment 1 Olivier Le Thanh Duong 2010-03-21 12:21:36 UTC 
Any reason to make this in the ImChannel class and not in connection RequestChannel?
Also I guess we have a similar issue when inviting a contact via the conference interface.
Comment 2 Jonny Lamb 2010-03-30 13:09:23 UTC 
(In reply to comment #1)
> Any reason to make this in the ImChannel class and not in connection
> RequestChannel?

I don't think it belongs there as there would be too many special-cases for different channel types such as conference, MUCs and 1-1.

> Also I guess we have a similar issue when inviting a contact via the conference
> interface.

Good point. I updated my patch to include this.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.