Bug 27235 - build failure: g_strjoin requires a NULL terminated list
Summary: build failure: g_strjoin requires a NULL terminated list
Status: RESOLVED FIXED
Alias: None
Product: cups-pk-helper
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Vincent Untz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-22 03:07 UTC by Dominique Leuenberger
Modified: 2010-03-22 03:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix the build by adding a NULL pointer to the list. (869 bytes, patch)
2010-03-22 03:07 UTC, Dominique Leuenberger 		Details | Splinter Review
View All

Description Dominique Leuenberger 2010-03-22 03:07:36 UTC 
Created attachment 34308 [details] [review]
Fix the build by adding a NULL pointer to the list.

From OBS build log:

I: Function call needs to pass NULL-pointer as last argument
E: cups-pk-helper missing-sentinel cups.c:1230, 1235

Tested with latest release, 0.1.0.

Find attached patch which fixes the error.
Comment 1 Vincent Untz 2010-03-22 03:36:55 UTC 
Good catch, but wrong patch :-) See http://cgit.freedesktop.org/cups-pk-helper/commit/?id=df2b6a40ac99360aafa05c71be28ee8a972bd8c4

I never noticed this since I didn't have a recent-enough cups when building cups-pk-helper.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.