Bug 27378 - Bad target type checking for handle type 0.
Summary: Bad target type checking for handle type 0.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-python (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: minor changes needed
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-03-30 13:36 UTC by Krzysztof Klinikowski
Modified: 2010-04-02 09:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
patch (608 bytes, patch)
2010-03-30 13:36 UTC, Krzysztof Klinikowski 		Details | Splinter Review
View All

Description Krzysztof Klinikowski 2010-03-30 13:36:26 UTC 
Created attachment 34548 [details] [review]
patch

tp-python have bad checking for target handle. It checking just is TargetHandle == None but it's never None I think. Correct checking should check is TargetHandle == 0. Without that ListRooms channel cannot be created.
Comment 1 Simon McVittie 2010-03-31 05:07:57 UTC 
Yes, this is a bug; requesting channels with (TargetHandleType=NONE, TargetHandle=0) should be allowed.

The InvalidArgument error message should also be changed to say "... omitted or 0", and the patch could be simplified by using "target_handle not in (0, None)". I'll leave it to telepathy-python people to apply this.
Comment 2 Jonny Lamb 2010-04-02 09:41:54 UTC 
Thanks for your patch. I made the changes Simon suggested and pushed to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.