Bug 28809 - Out off bound array access in EvdevRec.vals and EvdevRec.old_vals arrays
Summary: Out off bound array access in EvdevRec.vals and EvdevRec.old_vals arrays
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/evdev (show other bugs)
Version: git
Hardware: All All
: medium major
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-29 01:48 UTC by Alex Warg
Modified: 2010-06-30 15:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to fix the problem (1.55 KB, patch)
2010-06-29 01:48 UTC, Alex Warg 		no flags Details | Splinter Review
View All

Description Alex Warg 2010-06-29 01:48:26 UTC 
Created attachment 36595 [details] [review]
Patch to fix the problem

The functions EvdevAddRelClass and EvdevAddAbsClass do out off bounds accesses
to vals and old_vals arrays in the EvdevRec structure if there are more
than MAX_VALUATORS axes reported by the kernel.
Comment 1 Peter Hutterer 2010-06-29 17:41:07 UTC 
ACK, can I have your signed-off-by please for this patch please? Just stating it here will do. What the sign-off means (applies to us in the same way as to the kernel): 
http://www.mjmwired.net/kernel/Documentation/SubmittingPatches#286

For the future, please submit patches as git-formatted patches.
http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches

I've fixed this up for this one, so don't bother creating another one.
Comment 2 Alex Warg 2010-06-30 01:35:02 UTC 
Thanks for the comments,

the attached patch is
Signed-of-by: Alexander Warg <alexander.warg@os.inf.tu-dresden.de>
Comment 3 Peter Hutterer 2010-06-30 15:18:15 UTC 
thanks, committed

commit 421585fda6ce67c209d43952109dda056ee40941
Author: Alex Warg <alexander.warg@os.inf.tu-dresden.de>
Date:   Wed Jun 30 10:33:46 2010 +1000

    Fix out-of-bounds access if more than MAX_VALUATORS are present. (#28809)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.