Bug 2959 - [6.8.3] Displays :1 and up don't get utmp entries
Summary: [6.8.3] Displays :1 and up don't get utmp entries
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xdm (show other bugs)
Version: 6.8.2
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL: https://bugzilla.redhat.com/bugzilla/...
Whiteboard:
Keywords:
Depends on:
Blocks: 7247
  Show dependency treegraph
 
Reported: 2005-04-10 16:29 UTC by Mike A. Harris
Modified: 2011-10-15 15:33 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix for xdm-config.cpp to ensure logins on all displays make it to utmp (977 bytes, patch)
2005-04-10 16:37 UTC, Mike A. Harris
no flags Details | Splinter Review
Xstartup file for xdm (254 bytes, text/plain)
2005-04-10 16:40 UTC, Mike A. Harris
no flags Details
Xreset file for xdm (256 bytes, text/plain)
2005-04-10 16:41 UTC, Mike A. Harris
no flags Details
xorg-x11-6.8.2-xdm-config-utmp-fixes.patch (2.88 KB, patch)
2005-04-10 17:22 UTC, Mike A. Harris
mharris: 6.8-branch?
Details | Splinter Review

Description Mike A. Harris 2005-04-10 16:29:33 UTC
Displays :1 and up don't get utmp entries.

Originally reported in Red Hat bugzilla by Tim Waugh:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=20901

A fix for this issue is also attached to that bug report, and I'll
add the patches here also for review.
Comment 1 Mike A. Harris 2005-04-10 16:37:42 UTC
Created attachment 2375 [details] [review]
Fix for xdm-config.cpp to ensure logins on all displays make it to utmp
Comment 2 Mike A. Harris 2005-04-10 16:40:59 UTC
Created attachment 2376 [details]
Xstartup file for xdm
Comment 3 Mike A. Harris 2005-04-10 16:41:45 UTC
Created attachment 2377 [details]
Xreset file for xdm
Comment 4 Mike A. Harris 2005-04-10 16:44:34 UTC
The attached patch for xdm-config was made against the 6.8.2 release.

I'll also attach a unified diff containing all changes in one patch.
Comment 5 Mike A. Harris 2005-04-10 17:22:42 UTC
Created attachment 2378 [details] [review]
xorg-x11-6.8.2-xdm-config-utmp-fixes.patch

This unified diff was created against stock 6.8.2 sources.  It contains
of all of the above changes plus changes to the Imakefile to install the
new files in the right place.

It applies cleanly to 6.8.2, as well as CVS head (as of today).  Please
review and apply this to CVS head.  It should also be considered for the
stable branch, as there are security ramifications of displays not getting
logged in utmp.
Comment 6 Mike A. Harris 2005-04-10 17:23:42 UTC
Comment on attachment 2378 [details] [review]
xorg-x11-6.8.2-xdm-config-utmp-fixes.patch

Nominating for approval
for 6.8.x branch, once it
is committed to CVS head
first.
Comment 7 Adam Jackson 2005-06-19 19:59:35 UTC
applied to head.
Comment 8 Mike A. Harris 2006-07-21 14:54:31 UTC
Assuming from last comment, that this bug is now resolved.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.