Bug 37459 - Strange check in syndaemon for synaptics device
Summary: Strange check in syndaemon for synaptics device
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/synaptics (show other bugs)
Version: git
Hardware: Other All
: medium minor
Assignee: Peter Hutterer
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-22 03:05 UTC by Nick Schermer
Modified: 2011-06-27 21:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Nick Schermer 2011-05-22 03:05:45 UTC 
I was looking in the syndaemon code how it detects a synaptics device, but in the dp_get_device function I discovered a somewhat strange check:

if (properties[nprops] == synaptics_property)

Now it happens to be "Synaptics Off" is the 0 atom so the check succeeds, but it could break is someone else takes this atom.
Comment 1 Peter Hutterer 2011-05-22 17:47:17 UTC 
http://patchwork.freedesktop.org/patch/5554/
Comment 2 Peter Hutterer 2011-06-27 21:38:56 UTC 
commit be83094bd98c353b0ee7894eefcb1ae91e0cae30
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Mon May 23 10:18:22 2011 +1000

    syndaemon: don't compare against a null-property. (#37459)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.