Bug 40313 - Missing inclusion of inttypes.h in dbus/dbus-sysdeps.h
Summary: Missing inclusion of inttypes.h in dbus/dbus-sysdeps.h
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: SPARC Solaris
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 08:21 UTC by Dagobert Michelsen
Modified: 2011-08-24 04:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Add missing inclusion of inttypes.h (640 bytes, patch)
2011-08-23 08:25 UTC, Dagobert Michelsen 		Details | Splinter Review
View All

Description Dagobert Michelsen 2011-08-23 08:21:40 UTC 
There is an include missing when stdint.h is not available. The attached patch fixes the issue.
Comment 1 Dagobert Michelsen 2011-08-23 08:25:34 UTC 
Created attachment 50499 [details] [review]
Add missing inclusion of inttypes.h
Comment 2 Thiago Macieira 2011-08-23 14:51:08 UTC 
stdint.h and inttypes.h are both C99 headers. If one is not available, it's likely the other isn't either.
Comment 3 Thiago Macieira 2011-08-23 14:52:35 UTC 
Review of attachment 50499 [details] [review]:

Patch looks sane. I'm guessing you have such a system where one C99 header is present but the other isn't.
Comment 4 Dagobert Michelsen 2011-08-24 00:31:42 UTC 
Yes, this is the case. The same construct is in dbus-hash.h and dbus-pipe.h, just dbus-sysdeps.h was missing the additional include.
Comment 5 Simon McVittie 2011-08-24 03:35:57 UTC 
Thanks, fixed in git for 1.4.16, 1.5.8.

(But, seriously? It's 2011 and systems without stdint.h, specified in C99 12 years ago, are still relevant? Please complain to the platform vendor.)
Comment 6 Thiago Macieira 2011-08-24 04:02:20 UTC 
(In reply to comment #5)
> (But, seriously? It's 2011 and systems without stdint.h, specified in C99 12
> years ago, are still relevant? Please complain to the platform vendor.)

Unfortunately, yes. Microsoft, for example, has said they have no plans to add C99 support to Visual Studio.

Please complain to the vendor anyway.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.