Bug 4394 - tests can't assume Xlib requests will always be queued
Summary: tests can't assume Xlib requests will always be queued
Status: RESOLVED FIXED
Alias: None
Product: Xtests
Classification: Unclassified
Component: XTS (show other bugs)
Version: unspecified
Hardware: All All
: high normal
Assignee: Stuart Anderson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-07 20:54 UTC by Jamey Sharp
Modified: 2005-12-18 03:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Check for "auto-flush" behavior and report UNTESTED instead of FAIL. (738 bytes, patch)
2005-09-07 20:55 UTC, Jamey Sharp
Details | Splinter Review

Description Jamey Sharp 2005-09-07 20:54:23 UTC
The XEventsQueued test purpose #3 assumes that calls to XCreatePixmap won't be
immediately flushed. Xlib/XCB always immediately moves requests from Xlib's
output queue into XCB's. This test blames the fact that those requests aren't in
Xlib's queue any more on XEventsQueued, and reports FAIL.

I think the correct result in this case is UNTESTED, following the example of
the similar XFlush test. I've patched the test to check for this kind of
"auto-flush" behavior, and not run the rest of the test in that case. After
applying the patch, the test continues to PASS on X.org Xlib while producing
UNTESTED on Xlib/XCB.
Comment 1 Jamey Sharp 2005-09-07 20:55:48 UTC
Created attachment 3200 [details] [review]
Check for "auto-flush" behavior and report UNTESTED instead of FAIL.
Comment 2 Jamey Sharp 2005-12-18 22:24:29 UTC
Patch tested and committed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.