Bug 81885 - Using "Floating" option set to "On" causes server to SEGV
Summary: Using "Floating" option set to "On" causes server to SEGV
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Input/Core (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
: 88035 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-29 19:37 UTC by Simon Munton
Modified: 2015-01-05 09:40 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Xorg.log (16.01 KB, text/plain)
2014-07-29 19:37 UTC, Simon Munton
no flags Details
Patch to prevent NULL pointer being passed to XkbPushLockedStateToSlaves (431 bytes, patch)
2014-08-03 09:54 UTC, Simon Munton
no flags Details | Splinter Review

Description Simon Munton 2014-07-29 19:37:43 UTC
Created attachment 103654 [details]
Xorg.log

I was experimenting with adding a bluetooth keyboard/mouse (a Rii Mini) and as part of trying to get it set up, I had the following in a file in /etc/X11/xorg.conf.d

Section "InputClass"
    Identifier             "Keyboard Defaults 1"
    MatchProduct           "Macro Keyboard"
    MatchIsKeyboard        "yes"
    Option                 "xkb_model" "pc101"
    Option                 "XkbLayout" "us"
    Option                 "Floating" "On"
    Driver                 "evdev"
EndSection

With the Option "Floating" line present, X would crash either at startup if the device was already on, or later if the device was turned on after X had started.

Xorg.log attached.
Comment 1 Simon Munton 2014-08-03 09:54:19 UTC
Created attachment 103898 [details] [review]
Patch to prevent NULL pointer being passed to XkbPushLockedStateToSlaves

Found that when "Floating" was set to "on", XkbPushLockedStateToSlaves was called with a NULL pointer passed as first argument.

Patch checks for NULL pointer and if it is NULL then it does not call XkbPushLockedStateToSlaves
Comment 2 Peter Hutterer 2014-08-04 00:47:28 UTC
http://patchwork.freedesktop.org/patch/30908/
Comment 3 Simon Munton 2014-08-04 18:50:47 UTC
Confirming that Peter's patch fixes the problem
Comment 4 Nick Bowler 2014-10-14 01:42:49 UTC
This regression is still present in server 1.16.1... any reason the fix was not included?  It is impossible to start the server at all with this bug.
Comment 5 Peter Hutterer 2014-10-28 05:39:34 UTC
closing as fixed, patch is on master. sent a request for 1.16.2, so that should be done soon too.


commit 1e30fc1b99bda040038e4fd56d1b27c686b44c75
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Mon Aug 4 10:47:03 2014 +1000

    xkb: ignore floating slave devices when updating from master (#81885)
Comment 6 Peter Hutterer 2014-10-29 20:28:05 UTC
commit on the 1.16 branch: 0e62f275aa02c5694fd714f3bbd5271836142755
Comment 7 Peter Hutterer 2015-01-05 09:40:57 UTC
*** Bug 88035 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.