Bug 89300 - xf86-input-libinput stack smashing detected
Summary: xf86-input-libinput stack smashing detected
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/libinput (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-24 15:10 UTC by regwz
Modified: 2015-02-24 21:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
xf86-input-libinput compiled with AddressSanitizer (4.21 KB, text/plain)
2015-02-24 15:10 UTC, regwz 		no flags Details
View All

Description regwz 2015-02-24 15:10:32 UTC 
Created attachment 113795 [details]
xf86-input-libinput compiled with AddressSanitizer

Arch Linux
xf86-input-libinput 0.7.0
xorg-server 1.17.1-3

Xorg crashes during startup with xf86-input-libinput installed (stack smashing protection is enabled with -fstack-protector-strong)

I recompiled the driver with AddressSanitizer enabled and was able to find the cause of the crash which seems to be an off-by-one error on line 375 of libinput.c.
Comment 1 Peter Hutterer 2015-02-24 21:52:54 UTC 
Thanks, made it easy with this backtrace :)


commit 2600a4a352185f7d4d828f7d223628e4bb0f2aa3
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Wed Feb 25 07:48:18 2015 +1000

    Fix off-by-one error in buttonmap initialization (#89300)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.