Bug 93712 - gnome GDK pixbuf loader does not set GError
Summary: gnome GDK pixbuf loader does not set GError
Status: RESOLVED FIXED
Alias: None
Product: libopenraw
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Hubert Figuiere
QA Contact:
URL:
Whiteboard: [release:0.1.0]
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-14 14:50 UTC by wim.taymans@gmail.com
Modified: 2016-11-27 05:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
proposed patch (1.29 KB, text/plain)
2016-01-14 14:50 UTC, wim.taymans@gmail.com
Details

Description wim.taymans@gmail.com 2016-01-14 14:50:22 UTC
Created attachment 121035 [details]
proposed patch

gdk_pixbuf__or_image_stop_load can return FALSE when the image fails to load, in which case the caller can expect the GError to be set. The code however does not set the error and an attempt by the caller (nautilus) to get the error message cause a segfault.
Comment 1 Hubert Figuiere 2016-01-24 18:35:13 UTC
Fixed in master f19e73bd7d573c66242c9a2d02246fefaf94f74e

And in the 0.0.8-api branch 61b4f359b8ce310dae3f0d1fd51274c6537172ee


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.