Bug 9372 - headers installed by cairo are busted
Summary: headers installed by cairo are busted
Status: RESOLVED NOTABUG
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.3.9
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-16 18:57 UTC by Jory A. Pratt
Modified: 2008-10-10 04:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
cairo-1.3.8-headers.patch (2.48 KB, text/x-patch)
2006-12-16 18:57 UTC, Jory A. Pratt
Details

Description Jory A. Pratt 2006-12-16 18:57:25 UTC
The headers that are installed by default with cairo are busted. I will attach a
patch that should address the issue .. It might not be complete but figured you
all would know a bit more about that then me.
Comment 1 Jory A. Pratt 2006-12-16 18:57:51 UTC
Created attachment 8142 [details]
cairo-1.3.8-headers.patch
Comment 2 Behdad Esfahbod 2006-12-16 19:20:43 UTC
It's not a bug.  You should be adding the right -I to your CFLAGS (by way of
using `pkg-config --cflags cairo` for example) and #include <cairo.h>.  I'm not
sure if we want to support #include <cairo/cairo.h>.  In that case we should
switch to #include "cairo.h" syntax in the public header files.

I'm fine either way.  Carl?
Comment 3 Chris Wilson 2008-10-10 04:51:46 UTC
This debate occassionally rages on (e.g. http://www.nabble.com/internal-cairo-include-syntax-seems-not-flexible-enough,-backward-compatible-fix-proposal.-td19583394.html), in short #include <cairo/cairo.h> is more likely to lead to subtle bugs.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.