Bug 33846 - Watt's-Up udev rule is far too general
Summary: Watt's-Up udev rule is far too general
Status: RESOLVED FIXED
Alias: None
Product: upower
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 09:26 UTC by Ben Gamari
Modified: 2013-10-14 08:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Ben Gamari 2011-02-02 09:26:54 UTC
The Watt's-Up udev rule is far too general and catches quite a few unrelated devices containing FTDI USB devices. This causes the user to get a perplexing "Device or resource busy" error when attempting to use their device. In particular, it appears the criterion currently used catches any FTDI device,

  Watt's Up rule:
    serial: A80?????
    vendor: 0403
    product: 6001

  Sparkfun FT232 breakout board: My own
    serial: A800el9N
    vendor: 0403
    product: 6001

  Parallax Propeller: See bug[1]
    serial: A8007b1Z
    vendor: 0403
    product: 6001

This rule needs to be removed until a more selective criterion is identified. It's unacceptable to break a whole class of generic devices simply because a vendor doesn't include any usable identification in their device.
Comment 1 sam tygier 2011-02-02 14:42:02 UTC
probably worth linking to the ubuntu bug https://bugs.launchpad.net/ubuntu/+source/devicekit-power/+bug/507247

it also cause problems for arduinos
Comment 2 Richard Hughes 2011-02-03 02:05:20 UTC
upower should release the device if the identification string isn't received. Isn't this happening?
Comment 3 Matthieu Herrb 2011-03-11 03:26:30 UTC
For completeness there's a Debian bug too:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586751
Comment 4 Richard Hughes 2011-03-14 04:02:07 UTC
I've pushed this:

commit b0bbb29df1363e4c7c51564506b45b42bf71137c
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Mar 14 11:01:12 2011 +0000

    Add a config option 'EnableWattsUpPro' to disable the Watts Up Pro device
    
    Annoyingly, the device used in the Watts Up Pro device seems to be a generic
    USB->serial adaptor, which means it doesn't have a unique vendor and product
    ID. If we try to probe for the WUP device, we can actually upset other devices
    that are not expecing to be probed. This fixes #33846 although we actually
    still need to be more strict in detecting a true WUP device.
Comment 5 Bastien Nocera 2013-10-14 08:19:59 UTC
commit 6abd4123ef2808d1ff35fe7656922f314e68c9a8
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sat Oct 12 14:55:30 2013 +0200

    linux: Opt-out of checking Watts Up devices earlier
    
    Don't wait for tty events from udev if we're not going to
    use the Watts Up device anyway. Cuts down on the possible wakeups.

commit d6bfaaf0aac5cac01d3abf9059703252286f4566
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sat Oct 12 14:46:39 2013 +0200

    etc: Disable Watts-Up devices by default
    
    They are few are far between, and users of the device can
    spare the time to enable this by default.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=33846


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.