Bug 34896 - Color palette: number of columns
Summary: Color palette: number of columns
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: color_handling
Keywords: easyHack
Depends on:
Blocks:
 
Reported: 2011-03-01 22:30 UTC by Hillar
Modified: 2015-12-18 09:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hillar 2011-03-01 22:30:46 UTC
Options - Colours. Colours are OK. It have 8 columns:
http://ubuntuone.com/p/aFh/

Font and other colours selector. Colours are not OK, because it have 10 columns and colours are messed up. Now the colour palette is made to work with 8 columns.
http://ubuntuone.com/p/aFj/

Both should have same number columns then it's possible to make colour palette that fits.
Comment 2 Hillar 2011-03-02 02:49:12 UTC
(In reply to comment #1)
> This could be an easy hack. See these files for the changes:
> 
> http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/colrctrl.cxx
> http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/colrctrl.src

Is
294     aColorSize		( 14, 14 )
in http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/colrctrl.cxx
place where 14 must be changed to 10 or 11?
If yes, can somebody change it? (I don't know how to do it!)
Comment 3 Xavier ALT 2011-03-05 01:23:02 UTC
Hi Hillar,

I've digged a little bit and found that:

- size of "Tools -> Options, LibreOffice -> Colors" is defined here (8x12):
http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73

- size of "Tools -> Options, Chart -> Default Colors" is defined here (8x12):
http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73

- the color palette size is defined here (10x11):
http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/tbcontrl.cxx#815

So it's not consistent. I can make a patch, but I don't known what is the good way:
- change to 8x12
- change to 10x11

If someone can give me some advise :)
Comment 4 Hillar 2011-03-05 02:11:37 UTC
(In reply to comment #3)
> Hi Hillar,
> 
> I've digged a little bit and found that:
> 
> - size of "Tools -> Options, LibreOffice -> Colors" is defined here (8x12):
> http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73
> 
> - size of "Tools -> Options, Chart -> Default Colors" is defined here (8x12):
> http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73
> 
> - the color palette size is defined here (10x11):
> http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/tbcontrl.cxx#815
> 
> So it's not consistent. I can make a patch, but I don't known what is the good
> way:
> - change to 8x12
> - change to 10x11
> 
> If someone can give me some advise :)


I am asking it from design mailing list.
Comment 5 Hillar 2011-03-05 06:16:15 UTC
(In reply to comment #3)
> Hi Hillar,
> 
> I've digged a little bit and found that:
> 
> - size of "Tools -> Options, LibreOffice -> Colors" is defined here (8x12):
> http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73
> 
> - size of "Tools -> Options, Chart -> Default Colors" is defined here (8x12):
> http://opengrok.libreoffice.org/xref/components/cui/source/options/optchart.cxx#73
> 
> - the color palette size is defined here (10x11):
> http://opengrok.libreoffice.org/xref/libs-core/svx/source/tbxctrls/tbcontrl.cxx#815
> 
> So it's not consistent. I can make a patch, but I don't known what is the good
> way:
> - change to 8x12
> - change to 10x11
> 
> If someone can give me some advise :)

8x12, if no scrollbars needed to use.
Comment 6 Xavier ALT 2011-03-05 08:40:43 UTC
(In reply to comment #5)
> (In reply to comment #3)
> 
> 8x12, if no scrollbars needed to use.

Well, actually using 8x12, the scrollbar is visible everywhere :/. I will to tune the resource size to fit it.
Comment 7 Xavier ALT 2011-03-06 09:28:30 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > 
> > 8x12, if no scrollbars needed to use.
> 
> Well, actually using 8x12, the scrollbar is visible everywhere :/. I will to
> tune the resource size to fit it.

Hi Hillar,

I changed to color palette to 8x13 to be ok. I also tweak "Options -> Chart -> Default colors" and "Background tab" (paragraph property, ...) to only show scrollbar if color palette is bigger than 8x13.

Patches where sumbitted to the development mailling list today. :)
Comment 8 Caolán McNamara 2011-03-11 12:39:46 UTC
Seems sane, 8x13 everywhere and drop scrollbars when not needed. Works for me, thanks for these.
Comment 9 Rainer Bielefeld Retired 2012-04-10 02:44:08 UTC
EasyHack tags unification: tags only allowed in Whiteboard to make queries more easy and reliable
Comment 10 Robinson Tryon (qubit) 2015-12-18 09:58:38 UTC
Migrating Whiteboard tags to Keywords: (EasyHack)
[NinjaEdit]