Attachment 100506 Details for Bug 79423 – drm/i915: set backlight duty cycle after backlight enable for gen4

[patch] drm/i915: set backlight duty cycle after backlight enable for gen4

0001-drm-i915-set-backlight-duty-cycle-after-backlight-en.patch (text/plain), 1.40 KB, created by Jani Nikula on 2014-06-06 06:33:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-06-06 06:33:00 UTC

Size: 1.40 KB

patch

obsolete

>From f90b5c33a01099464bef503bdd986f02fd8c8c91 Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Fri, 6 Jun 2014 09:30:23 +0300
>Subject: [PATCH] drm/i915: set backlight duty cycle after backlight enable for
> gen4
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_panel.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>index 5e6c888b4928..38a98570d10c 100644
>--- a/drivers/gpu/drm/i915/intel_panel.c
>+++ b/drivers/gpu/drm/i915/intel_panel.c
>@@ -798,9 +798,6 @@ static void i965_enable_backlight(struct intel_connector *connector)
> 	ctl = freq << 16;
> 	I915_WRITE(BLC_PWM_CTL, ctl);
> 
>-	/* XXX: combine this into above write? */
>-	intel_panel_actually_set_backlight(connector, panel->backlight.level);
>-
> 	ctl2 = BLM_PIPE(pipe);
> 	if (panel->backlight.combination_mode)
> 		ctl2 |= BLM_COMBINATION_MODE;
>@@ -809,6 +806,8 @@ static void i965_enable_backlight(struct intel_connector *connector)
> 	I915_WRITE(BLC_PWM_CTL2, ctl2);
> 	POSTING_READ(BLC_PWM_CTL2);
> 	I915_WRITE(BLC_PWM_CTL2, ctl2 | BLM_PWM_ENABLE);
>+
>+	intel_panel_actually_set_backlight(connector, panel->backlight.level);
> }
> 
> static void vlv_enable_backlight(struct intel_connector *connector)
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 79423: 100119 | 100120 | 100479 | 100480 | 100506 | 100579

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.