Attachment 100590 Details for Bug 79762 – Include stdio.h from poppler-config.h

[patch] Include stdio.h from poppler-config.h

Include-stdioh-from-poppler-configh.patch (text/plain), 1.43 KB, created by Hib Eris on 2014-06-07 08:15:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hib Eris

Created: 2014-06-07 08:15:01 UTC

Size: 1.43 KB

patch

obsolete

>From e942b7540820266491b3beb23b528d43fb2c562d Mon Sep 17 00:00:00 2001
>From: Hib Eris <hib@hiberis.nl>
>Date: Thu, 29 May 2014 16:58:55 +0200
>Subject: [PATCH] Include stdio.h from poppler-config.h
>
>In poppler-config.h there is a check for __MINGW_PRINTF_FORMAT,
>which is set by stdio.h.
>
>This fixes this warning when compling with the mingw-w64-compiler:
>
>XRef.cc: In member function 'virtual void
>XRef::XRefTableWriter::writeEntry(Goffset, int, XRefEntryType)':
>XRef.cc:1460:94: warning: unknown conversion type character 'l' in format [-Wformat=]
>    outStr->printf("%010lli %05i %c\r\n", (long long)offset, gen, (type==xrefEntryFree)?'f':'n');
>^
>XRef.cc:1460:94: warning: format '%i' expects argument of type 'int', but argument 3 has type 'Goffset {aka long long int}' [-Wformat=]
>XRef.cc:1460:94: warning: too many arguments for format [-Wformat-extra-args]
>
>https://bugs.freedesktop.org/show_bug.cgi?id=79762
>---
> poppler/poppler-config.h.in | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/poppler/poppler-config.h.in b/poppler/poppler-config.h.in
>index 8715406..d26b7bf 100644
>--- a/poppler/poppler-config.h.in
>+++ b/poppler/poppler-config.h.in
>@@ -23,6 +23,8 @@
> #ifndef POPPLER_CONFIG_H
> #define POPPLER_CONFIG_H
> 
>+#include <stdio.h>
>+
> // We duplicate some of the config.h #define's here since they are
> // used in some of the header files we install.  The #ifndef/#endif
> // around #undef look odd, but it's to silence warnings about
>-- 
>1.8.3.2

Actions: View | Splinter Review

Attachments on bug 79762: 100590

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.