Attachment 101277 Details for Bug 79709 – Removes the flip_pending vblank from the window_list, preventing it from being destroyed when the window is destroyed

[patch] Removes the flip_pending vblank from the window_list, preventing it from being destroyed when the window is destroyed

0001-present-Remove-executing-vblank-from-window-list.-Bu.patch (text/plain), 1.03 KB, created by Keith Packard on 2014-06-17 22:56:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Packard

Created: 2014-06-17 22:56:32 UTC

Size: 1.03 KB

patch

obsolete

>From 382ff4a306b97b0ddcdac03ce8611b026ca5323b Mon Sep 17 00:00:00 2001
>From: Keith Packard <keithp@keithp.com>
>Date: Tue, 17 Jun 2014 15:50:48 -0700
>Subject: [PATCH] present: Remove executing vblank from window list. Bug#
> 79709.
>
>Once the vblank is actually getting executed, it's lifetime is no
>longer tied to the window, and so it shouldn't be controlled by window
>destruction. In particular, if the vblank is queued for flip, it will
>get stored in the flip_pending field, and will be correctly destroyed
>when the flip completes.
>
>Signed-off-by: Keith Packard <keithp@keithp.com>
>---
> present/present.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/present/present.c b/present/present.c
>index 1bf3a58..165860a 100644
>--- a/present/present.c
>+++ b/present/present.c
>@@ -578,6 +578,7 @@ present_execute(present_vblank_ptr vblank, uint64_t ust, uint64_t crtc_msc)
>     }
> 
>     xorg_list_del(&vblank->event_queue);
>+    xorg_list_del(&vblank->window_list);
>     vblank->queued = FALSE;
> 
>     if (vblank->pixmap && vblank->window) {
>-- 
>2.0.0.rc4
>

Actions: View | Splinter Review

Attachments on bug 79709: 100498 | 100499 | 101277

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.