Attachment 102075 Details for Bug 80531 – add deep color module option

[patch] add deep color module option

0001-drm-radeon-add-a-module-parameter-to-control-deep-co.patch (text/plain), 2.72 KB, created by Alex Deucher on 2014-07-01 15:28:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2014-07-01 15:28:36 UTC

Size: 2.72 KB

patch

obsolete

>From a624f4290ab09e996b1040c3a349241f76742327 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Tue, 1 Jul 2014 11:23:03 -0400
>Subject: [PATCH] drm/radeon: add a module parameter to control deep color
> support
>
>Some monitors seem to have problems with deep color enabled, even
>though they claim to support it.  I'm not sure if the monitor
>need a quirk or if the driver is doing something the monitor doesn't
>like.  At this point lets just disable deep color by default like
>we did for hdmi audio and work through the bugs so we can eventually
>enable it by default.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=80531
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/radeon.h            | 1 +
> drivers/gpu/drm/radeon/radeon_connectors.c | 3 +++
> drivers/gpu/drm/radeon/radeon_drv.c        | 4 ++++
> 3 files changed, 8 insertions(+)
>
>diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
>index 4b0bbf8..a2e1ed8 100644
>--- a/drivers/gpu/drm/radeon/radeon.h
>+++ b/drivers/gpu/drm/radeon/radeon.h
>@@ -102,6 +102,7 @@ extern int radeon_runtime_pm;
> extern int radeon_hard_reset;
> extern int radeon_vm_size;
> extern int radeon_vm_block_size;
>+extern int radeon_deep_color;
> 
> /*
>  * Copy from radeon_drv.h so we don't have to include both and have conflicting
>diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
>index 1b9177e..4483119 100644
>--- a/drivers/gpu/drm/radeon/radeon_connectors.c
>+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
>@@ -199,6 +199,9 @@ int radeon_get_monitor_bpc(struct drm_connector *connector)
> 		}
> 	}
> 
>+	if ((radeon_deep_color == 0) && (bpc > 8))
>+		bpc = 8;
>+
> 	DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
> 			  connector->name, connector->display_info.bpc, bpc);
> 
>diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
>index 6e30174..cb14213 100644
>--- a/drivers/gpu/drm/radeon/radeon_drv.c
>+++ b/drivers/gpu/drm/radeon/radeon_drv.c
>@@ -175,6 +175,7 @@ int radeon_runtime_pm = -1;
> int radeon_hard_reset = 0;
> int radeon_vm_size = 4096;
> int radeon_vm_block_size = 9;
>+int radeon_deep_color = 0;
> 
> MODULE_PARM_DESC(no_wb, "Disable AGP writeback for scratch registers");
> module_param_named(no_wb, radeon_no_wb, int, 0444);
>@@ -248,6 +249,9 @@ module_param_named(vm_size, radeon_vm_size, int, 0444);
> MODULE_PARM_DESC(vm_block_size, "VM page table size in bits (default 9)");
> module_param_named(vm_block_size, radeon_vm_block_size, int, 0444);
> 
>+MODULE_PARM_DESC(deep_color, "Deep Color support (1 = enable, 0 = disable (default))");
>+module_param_named(deep_color, radeon_deep_color, int, 0444);
>+
> static struct pci_device_id pciidlist[] = {
> 	radeon_PCI_IDS
> };
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 80531: 101759 | 101760 | 101762 | 101763 | 101773 | 101866 | 101887 | 102075

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.