Attachment 102856 Details for Bug 81382 – set the default backlight level to something reasonable

[patch] set the default backlight level to something reasonable

0001-drm-radeon-set-default-bl-level-to-something-reasona.patch (text/plain), 1.81 KB, created by Alex Deucher on 2014-07-15 13:55:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2014-07-15 13:55:27 UTC

Size: 1.81 KB

patch

obsolete

>From 9655f09d422d4f820e4f8767d8300d5f2495dee6 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Tue, 15 Jul 2014 09:48:53 -0400
>Subject: [PATCH] drm/radeon: set default bl level to something reasonable
>
>If the value in the scratch register is 0, set it to the
>max level.  This fixes an issue where the console fb blanking
>code calls back into the backlight driver on unblank and then
>sets the backlight level to 0 after the driver has already
>set the mode and enabled the backlight.
>
>bugs:
>https://bugs.freedesktop.org/show_bug.cgi?id=81382
>https://bugs.freedesktop.org/show_bug.cgi?id=70207
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/radeon/atombios_encoders.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c
>index 2b29084..89eeb4a 100644
>--- a/drivers/gpu/drm/radeon/atombios_encoders.c
>+++ b/drivers/gpu/drm/radeon/atombios_encoders.c
>@@ -183,7 +183,6 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
> 	struct backlight_properties props;
> 	struct radeon_backlight_privdata *pdata;
> 	struct radeon_encoder_atom_dig *dig;
>-	u8 backlight_level;
> 	char bl_name[16];
> 
> 	/* Mac laptops with multiple GPUs use the gmux driver for backlight
>@@ -222,12 +221,12 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
> 
> 	pdata->encoder = radeon_encoder;
> 
>-	backlight_level = radeon_atom_get_backlight_level_from_reg(rdev);
>-
> 	dig = radeon_encoder->enc_priv;
> 	dig->bl_dev = bd;
> 
> 	bd->props.brightness = radeon_atom_backlight_get_brightness(bd);
>+	if (bd->props.brightness == 0)
>+		bd->props.brightness = RADEON_MAX_BL_LEVEL;
> 	bd->props.power = FB_BLANK_UNBLANK;
> 	backlight_update_status(bd);
> 
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 81382: 102847 | 102852 | 102856 | 106353 | 106354 | 106410 | 106441 | 106442 | 106554 | 115253

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.