Attachment 103679 Details for Bug 80880 – patch to fix ir_loop generation

[patch] patch to fix ir_loop generation

0001-glsl-support-unsigned-increment-in-ir_loop.patch (text/plain), 1.75 KB, created by Tapani Pälli on 2014-07-30 10:07:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2014-07-30 10:07:55 UTC

Size: 1.75 KB

patch

obsolete

>From 18706d9b6c428579bf10ae3de1d8c11e9907dc90 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Wed, 30 Jul 2014 13:02:52 +0300
>Subject: [PATCH] glsl: support unsigned increment in ir_loop
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Current version can create ir_expression where operands have
>different base type, oatch adds support for unsigned type.
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>https://bugs.freedesktop.org/show_bug.cgi?id=80880
>---
> src/glsl/loop_controls.cpp | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
>diff --git a/src/glsl/loop_controls.cpp b/src/glsl/loop_controls.cpp
>index 36b49eb..60f22ba 100644
>--- a/src/glsl/loop_controls.cpp
>+++ b/src/glsl/loop_controls.cpp
>@@ -123,9 +123,21 @@ calculate_iterations(ir_rvalue *from, ir_rvalue *to, ir_rvalue *increment,
>    bool valid_loop = false;
> 
>    for (unsigned i = 0; i < Elements(bias); i++) {
>-      iter = (increment->type->is_integer())
>-	 ? new(mem_ctx) ir_constant(iter_value + bias[i])
>-	 : new(mem_ctx) ir_constant(float(iter_value + bias[i]));
>+
>+      /* Increment may be of type int, uint or float. */
>+      switch (increment->type->base_type) {
>+      case GLSL_TYPE_INT:
>+         iter = new(mem_ctx) ir_constant(iter_value + bias[i]);
>+         break;
>+      case GLSL_TYPE_UINT:
>+         iter = new(mem_ctx) ir_constant(unsigned(iter_value + bias[i]));
>+         break;
>+      case GLSL_TYPE_FLOAT:
>+         iter = new(mem_ctx) ir_constant(float(iter_value + bias[i]));
>+         break;
>+      default:
>+         unreachable("not reached");
>+      }
> 
>       ir_expression *const mul =
> 	 new(mem_ctx) ir_expression(ir_binop_mul, increment->type, iter,
>-- 
>1.9.3
>

Actions: View | Splinter Review

Attachments on bug 80880: 103582 | 103679

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.