Attachment 103984 Details for Bug 81986 – drm/i915: make detecting of unclaimed registers optional

[patch] drm/i915: make detecting of unclaimed registers optional

0001-drm-i915-make-detecting-of-unclaimed-registers-optio.patch (text/plain), 1.88 KB, created by Mika Kuoppala on 2014-08-04 09:04:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2014-08-04 09:04:44 UTC

Size: 1.88 KB

patch

obsolete

>From 95140522b198bedf784378a61dea239b96dc0ec9 Mon Sep 17 00:00:00 2001
>From: Mika Kuoppala <mika.kuoppala@intel.com>
>Date: Mon, 4 Aug 2014 11:59:02 +0300
>Subject: [PATCH] drm/i915: make detecting of unclaimed registers optional
>
>to lessen the performance impact.
>
>Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>---
> drivers/gpu/drm/i915/i915_drv.h     |    2 +-
> drivers/gpu/drm/i915/intel_uncore.c |    6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>index d604f4f..5a8dc80 100644
>--- a/drivers/gpu/drm/i915/i915_drv.h
>+++ b/drivers/gpu/drm/i915/i915_drv.h
>@@ -2150,7 +2150,7 @@ struct i915_params {
> 	bool disable_display;
> 	bool disable_vtd_wa;
> 	int use_mmio_flip;
>-	bool mmio_debug;
>+	int mmio_debug;
> };
> extern struct i915_params i915 __read_mostly;
> 
>diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>index 54ecf1b..4506cdf 100644
>--- a/drivers/gpu/drm/i915/intel_uncore.c
>+++ b/drivers/gpu/drm/i915/intel_uncore.c
>@@ -517,7 +517,7 @@ static void
> hsw_unclaimed_reg_debug(struct drm_i915_private *dev_priv, u32 reg, bool read,
> 			bool before)
> {
>-	if (!i915.mmio_debug)
>+	if (i915.mmio_debug != 2)
> 		return;
> 
> 	if (__raw_i915_read32(dev_priv, FPGA_DBG) & FPGA_DBG_RM_NOCLAIM) {
>@@ -533,11 +533,11 @@ hsw_unclaimed_reg_debug(struct drm_i915_private *dev_priv, u32 reg, bool read,
> static void
> hsw_unclaimed_reg_detect(struct drm_i915_private *dev_priv)
> {
>-	if (i915.mmio_debug)
>+	if (i915.mmio_debug != 1)
> 		return;
> 
> 	if (__raw_i915_read32(dev_priv, FPGA_DBG) & FPGA_DBG_RM_NOCLAIM) {
>-		DRM_ERROR("Unclaimed register detected. Please use the i915.mmio_debug=1 to debug this problem.");
>+		DRM_ERROR("Unclaimed register detected. Please use the i915.mmio_debug=2 to debug this problem.");
> 		__raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM);
> 	}
> }
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 81986: 103983 | 103984 | 103998

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.