Attachment 104581 Details for Bug 82534 – Jose's patch

[patch] Jose's patch

0001-scons-do-not-include-headers-from-the-sources-lists.patch (text/plain), 1.06 KB, created by Emil Velikov on 2014-08-13 19:37:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emil Velikov

Created: 2014-08-13 19:37:19 UTC

Size: 1.06 KB

patch

obsolete

>From a0bfb40b33d5c9c84f7713d53dde04e255b17b05 Mon Sep 17 00:00:00 2001
>From: Jose Fonseca <jfonseca@vmware.com>
>Date: Wed, 13 Aug 2014 20:33:35 +0100
>Subject: [PATCH] scons: do not include headers from the sources lists
>
>The SCons documentation is not explicit on the topic yet building mesa
>with SCons and MSVC is known to have problems when headers are listed.
>So be safe just drop them for now.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82534
>---
> scons/custom.py | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/scons/custom.py b/scons/custom.py
>index 09c937e..043793b 100644
>--- a/scons/custom.py
>+++ b/scons/custom.py
>@@ -276,6 +276,9 @@ def parse_source_list(env, filename, names=None):
>                     # Prefer relative source paths, as absolute files tend to
>                     # cause duplicate actions.
>                     f = f[len(cur_srcdir + '/'):]
>+                # do not include any headers
>+                if f.endswith('.h'):
>+                    continue
>                 srcs.append(f)
> 
>         src_lists[sym] = srcs
>-- 
>2.0.2
>

Actions: View | Splinter Review

Attachments on bug 82534: 104581

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.