Attachment 104766 Details for Bug 82683 – patch "fixing" the issue by removing an optimization block

[patch] patch "fixing" the issue by removing an optimization block

fix-diff.txt (text/plain), 1.45 KB, created by Ben Foppa on 2014-08-17 17:12:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ben Foppa

Created: 2014-08-17 17:12:21 UTC

Size: 1.45 KB

patch

obsolete

>diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>index 96dacde..77c14cc 100644
>--- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>+++ b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
>@@ -240,28 +240,6 @@ intel_bufferobj_subdata(struct gl_context * ctx,
> 
>    assert(intel_obj);
> 
>-   /* See if we can unsynchronized write the data into the user's BO. This
>-    * avoids GPU stalls in unfortunately common user patterns (uploading
>-    * sequentially into a BO, with draw calls in between each upload).
>-    *
>-    * Once we've hit this path, we mark this GL BO as preferring stalling to
>-    * blits, so that we can hopefully hit this path again in the future
>-    * (otherwise, an app that might occasionally stall but mostly not will end
>-    * up with blitting all the time, at the cost of bandwidth)
>-    */
>-   if (brw->has_llc) {
>-      if (offset + size <= intel_obj->gpu_active_start ||
>-          intel_obj->gpu_active_end <= offset) {
>-         drm_intel_gem_bo_map_unsynchronized(intel_obj->buffer);
>-         memcpy(intel_obj->buffer->virtual + offset, data, size);
>-         drm_intel_bo_unmap(intel_obj->buffer);
>-
>-         if (intel_obj->gpu_active_end > intel_obj->gpu_active_start)
>-            intel_obj->prefer_stall_to_blit = true;
>-         return;
>-      }
>-   }
>-
>    busy =
>       drm_intel_bo_busy(intel_obj->buffer) ||
>       drm_intel_bo_references(brw->batch.bo, intel_obj->buffer);

Actions: View | Splinter Review

Attachments on bug 82683: 104697 | 104766 | 106164

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.