Attachment 105755 Details for Bug 83500 – Better fix

[patch] Better fix

0001-radeonsi-disable-1D-tiled-DMA-copies.patch (text/plain), 1.01 KB, created by Grigori Goronzy on 2014-09-04 15:50:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Grigori Goronzy

Created: 2014-09-04 15:50:58 UTC

Size: 1.01 KB

patch

obsolete

>From 8e86c212679ff44238c2ff64d522cf2822a992f6 Mon Sep 17 00:00:00 2001
>From: Grigori Goronzy <greg@chown.ath.cx>
>Date: Thu, 4 Sep 2014 15:48:29 +0200
>Subject: [PATCH] radeonsi: disable 1D tiled DMA copies
>
>These cause hangs for some reason, should be investigated.
>---
> src/gallium/drivers/radeonsi/si_dma.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/gallium/drivers/radeonsi/si_dma.c b/src/gallium/drivers/radeonsi/si_dma.c
>index 4a87f79..15e70f7 100644
>--- a/src/gallium/drivers/radeonsi/si_dma.c
>+++ b/src/gallium/drivers/radeonsi/si_dma.c
>@@ -324,6 +324,10 @@ void si_dma_copy(struct pipe_context *ctx,
> 		si_dma_copy_buffer(sctx, dst, src, dst_offset, src_offset,
> 			    src_box->height * src_pitch);
> 	} else {
>+		/* XXX: DMA copy is broken with 1D surfaces */
>+		if (dst_mode == RADEON_SURF_MODE_1D || src_mode == RADEON_SURF_MODE_1D)
>+			goto fallback;
>+
> 		si_dma_copy_tile(sctx, dst, dst_level, dst_x, dst_y, dst_z,
> 				 src, src_level, src_x, src_y, src_box->z,
> 				 copy_height, dst_pitch, bpp);
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 83500: 105745 | 105755

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.