Attachment 106065 Details for Bug 16924 – dbus_shutdown: document its effect on shared connections

[patch] dbus_shutdown: document its effect on shared connections

0001-dbus_shutdown-document-its-effect-on-shared-connecti.patch (text/plain), 1.45 KB, created by Simon McVittie on 2014-09-10 15:22:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-09-10 15:22:00 UTC

Size: 1.45 KB

patch

obsolete

>From fdbecdb64a3562433fb44139d5ce702d48e99d15 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 10 Sep 2014 16:20:52 +0100
>Subject: [PATCH] dbus_shutdown: document its effect on shared connections
>
>In practice, the sort of applications that call dbus_shutdown()
>(e.g. regression tests) will want to either use private connections,
>or turn off exit-on-disconnect on the shared connection, or both.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16924
>---
> dbus/dbus-memory.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/dbus/dbus-memory.c b/dbus/dbus-memory.c
>index 22e8072..67d5cb0 100644
>--- a/dbus/dbus-memory.c
>+++ b/dbus/dbus-memory.c
>@@ -862,6 +862,13 @@ _dbus_register_shutdown_func_unlocked (DBusShutdownFunction  func,
>  * You MUST free all memory and release all reference counts
>  * returned to you by libdbus prior to calling dbus_shutdown().
>  *
>+ * If a shared connection is open, calling dbus_shutdown() will
>+ * drain its queue of messages and disconnect it. In particular,
>+ * this will result in processing of the special Disconnected
>+ * signal, which may result in a call to _exit(), unless you
>+ * have used dbus_connection_set_exit_on_disconnect() to disable
>+ * that behaviour.
>+ *
>  * You can't continue to use any D-Bus objects, such as connections,
>  * that were allocated prior to dbus_shutdown(). You can, however,
>  * start over; call dbus_threads_init() again, create new connections,
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 16924: 18041 | 106065

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.