Attachment 106199 Details for Bug 83445 – egl/drm: do not crash when swapping buffers without any rendering

[patch] egl/drm: do not crash when swapping buffers without any rendering

0001-egl-drm-do-not-crash-when-swapping-buffers-without-a.patch (text/plain), 1.24 KB, created by Lionel Landwerlin on 2014-09-12 17:09:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lionel Landwerlin

Created: 2014-09-12 17:09:17 UTC

Size: 1.24 KB

patch

obsolete

>From 91da65fe73280b306f0693ef4c3455031ed2804f Mon Sep 17 00:00:00 2001
>From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>Date: Fri, 12 Sep 2014 18:02:59 +0100
>Subject: [PATCH] egl/drm: do not crash when swapping buffers without any
> rendering
>
>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>---
> src/egl/drivers/dri2/platform_drm.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c
>index 70bd7d4..f6b9c3a 100644
>--- a/src/egl/drivers/dri2/platform_drm.c
>+++ b/src/egl/drivers/dri2/platform_drm.c
>@@ -418,6 +418,14 @@ dri2_drm_swap_buffers(_EGLDriver *drv, _EGLDisplay *disp, _EGLSurface *draw)
>          for (i = 0; i < ARRAY_SIZE(dri2_surf->color_buffers); i++)
>             if (dri2_surf->color_buffers[i].age > 0)
>                dri2_surf->color_buffers[i].age++;
>+
>+         /* Make sure we have a back buffer in case we're swapping without
>+          * ever rendering. */
>+         if (get_back_bo(dri2_surf) < 0) {
>+            _eglError(EGL_BAD_ALLOC, "dri2_swap_buffers");
>+            return EGL_FALSE;
>+         }
>+
>          dri2_surf->current = dri2_surf->back;
>          dri2_surf->current->age = 1;
>          dri2_surf->back = NULL;
>-- 
>2.0.1
>

Actions: View | Splinter Review

Attachments on bug 83445: 106199

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.