Attachment 106300 Details for Bug 83816 – More backlight debug

[patch] More backlight debug

brightness.diff (text/plain), 2.09 KB, created by Chris Wilson on 2014-09-15 06:35:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2014-09-15 06:35:06 UTC

Size: 2.09 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>index 6ec2ae052d76..2f00ddb4a4e7 100644
>--- a/drivers/gpu/drm/i915/intel_panel.c
>+++ b/drivers/gpu/drm/i915/intel_panel.c
>@@ -641,6 +641,9 @@ static void intel_panel_set_backlight(struct intel_connector *connector,
> 	hw_level = scale_user_to_hw(connector, user_level, user_max);
> 	panel->backlight.level = hw_level;
> 
>+	DRM_DEBUG_KMS("user level = %d/%d, backlight = %d\n",
>+		      user_level, user_max, hw_level);
>+
> 	if (panel->backlight.enabled)
> 		intel_panel_actually_set_backlight(connector, hw_level);
> 
>@@ -670,11 +673,18 @@ void intel_panel_set_backlight_acpi(struct intel_connector *connector,
> 	hw_level = clamp_user_to_hw(connector, user_level, user_max);
> 	panel->backlight.level = hw_level;
> 
>-	if (panel->backlight.device)
>+	DRM_DEBUG_KMS("user level = %d/%d, backlight = %d\n",
>+		      user_level, user_max, hw_level);
>+
>+	if (panel->backlight.device) {
> 		panel->backlight.device->props.brightness =
> 			scale_hw_to_user(connector,
> 					 panel->backlight.level,
> 					 panel->backlight.device->props.max_brightness);
>+		DRM_DEBUG_KMS("brightness = %d/%d\n",
>+			      panel->backlight.device->props.brightness,
>+			      panel->backlight.device->props.max_brightness);
>+	}
> 
> 	if (panel->backlight.enabled)
> 		intel_panel_actually_set_backlight(connector, hw_level);
>@@ -949,12 +959,18 @@ void intel_panel_enable_backlight(struct intel_connector *connector)
> 	WARN_ON(panel->backlight.max == 0);
> 
> 	if (panel->backlight.level == 0) {
>+		DRM_DEBUG_KMS("overriding backlight level of 0, setting max %d\n",
>+			      panel->backlight.max);
> 		panel->backlight.level = panel->backlight.max;
>-		if (panel->backlight.device)
>+		if (panel->backlight.device) {
> 			panel->backlight.device->props.brightness =
> 				scale_hw_to_user(connector,
> 						 panel->backlight.level,
> 						 panel->backlight.device->props.max_brightness);
>+			DRM_DEBUG_KMS("brightness = %d/%d\n",
>+				      panel->backlight.device->props.brightness,
>+				      panel->backlight.device->props.max_brightness);
>+		}
> 	}
> 
> 	dev_priv->display.enable_backlight(connector);

Actions: View | Splinter Review

Attachments on bug 83816: 106253 | 106254 | 106300

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.