Attachment 106927 Details for Bug 83338 – Possible fix

[patch] Possible fix

0008-drm-i915-call-intel_uncore_early_sanitize-when-runti.patch (text/plain), 1.33 KB, created by Paulo Zanoni on 2014-09-26 17:11:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo Zanoni

Created: 2014-09-26 17:11:42 UTC

Size: 1.33 KB

patch

obsolete

>From cc6751be806744324202d1bc69f646068bb0f728 Mon Sep 17 00:00:00 2001
>From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>Date: Fri, 27 Jun 2014 10:31:40 -0300
>Subject: [PATCH 08/36] drm/i915: call intel_uncore_early_sanitize when runtime
> resuming
>
>On BDW, I am seeing some "Unclaimed register" messages at this point
>of the runtime resume sequence. Since at this point our driver is just
>resuming, the code that is causing the bug is probably outside
>i915.ko. So to avoid the bug reports, let's keep the sanitize() call
>here for now and add a FIXME tag.
>
>Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>---
> drivers/gpu/drm/i915/i915_drv.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>index bdb223c..672694b 100644
>--- a/drivers/gpu/drm/i915/i915_drv.c
>+++ b/drivers/gpu/drm/i915/i915_drv.c
>@@ -1449,6 +1449,13 @@ static int intel_runtime_resume(struct device *device)
> 
> 	DRM_DEBUG_KMS("Resuming device\n");
> 
>+	/*
>+	 * FIXME: This call is hiding a BDW bug, but since what happened since
>+	 * we put the device back to PCI D0 until this point is not really
>+	 * important, let's hide the bug until we can find what is causing it.
>+	 */
>+	intel_uncore_early_sanitize(dev, true);
>+
> 	intel_opregion_notify_adapter(dev, PCI_D0);
> 	dev_priv->pm.suspended = false;
> 
>-- 
>2.0.0
>

Actions: View | Splinter Review

Attachments on bug 83338: 105537 | 106927

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.