Attachment 107128 Details for Bug 84500 – dump full CS when we hit a packet 0

[patch] dump full CS when we hit a packet 0

0001-drm-radeon-si-print-full-CS-when-we-hit-a-packet-0.patch (text/plain), 1.34 KB, created by Alex Deucher on 2014-09-30 13:28:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2014-09-30 13:28:15 UTC

Size: 1.34 KB

patch

obsolete

>From c2fc8068663cb1ecebded73e7fe456ed2e2f32f8 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Tue, 30 Sep 2014 09:25:32 -0400
>Subject: [PATCH] drm/radeon/si: print full CS when we hit a packet 0
>
>We should never have a packet 0 in the command stream.
>Dump the full command stream to help debug.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=84500
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/si.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
>index 6bce408..423a8cd 100644
>--- a/drivers/gpu/drm/radeon/si.c
>+++ b/drivers/gpu/drm/radeon/si.c
>@@ -4684,7 +4684,7 @@ static int si_vm_packet3_compute_check(struct radeon_device *rdev,
> int si_ib_parse(struct radeon_device *rdev, struct radeon_ib *ib)
> {
> 	int ret = 0;
>-	u32 idx = 0;
>+	u32 idx = 0, i;
> 	struct radeon_cs_packet pkt;
> 
> 	do {
>@@ -4695,6 +4695,12 @@ int si_ib_parse(struct radeon_device *rdev, struct radeon_ib *ib)
> 		switch (pkt.type) {
> 		case RADEON_PACKET_TYPE0:
> 			dev_err(rdev->dev, "Packet0 not allowed!\n");
>+			for (i = 0; i < ib->length_dw; i++) {
>+				if (i == idx)
>+					printk("\t0x%08x <---\n", ib->ptr[i]);
>+				else
>+					printk("\t0x%08x\n", ib->ptr[i]);
>+			}
> 			ret = -EINVAL;
> 			break;
> 		case RADEON_PACKET_TYPE2:
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 84500: 107128 | 107162 | 107281 | 113076 | 114385 | 114754 | 118502

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.