Attachment 107610 Details for Bug 84833 – Proposed Patch

[patch] Proposed Patch

fix-print-range.patch (text/plain), 1.41 KB, created by t_d_l_c on 2014-10-09 12:00:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: t_d_l_c

Created: 2014-10-09 12:00:40 UTC

Size: 1.41 KB

patch

obsolete

>--- a/qt4/src/poppler-ps-converter.cc
>+++ b/qt4/src/poppler-ps-converter.cc
>@@ -214,12 +214,31 @@
> 	char* pstitlechar;
> 	if (!d->title.isEmpty()) pstitlechar = pstitle8Bit.data();
> 	else pstitlechar = 0;
>+
>+	/* Calculate min and max page for creating the ps-file.
>+	*  This was introduced because before all pages where
>+	*  put in the ps file, which was very inefficent
>+	*  when printing a single page in a huge pdf file.
>+	*  TODO:
>+	*  Do you need to calculate min/max? Or can you rely
>+	*  on the first and last element of pageList?
>+        */
>+	int minPage=0;
>+	int maxPage=0;
>+        if(d->pageList.size()>0) {
>+		minPage = maxPage = d->pageList[0];
>+	}
>+	for(int i=1; i<d->pageList.size(); i++) {
>+		int currentPage = d->pageList[i];
>+		if(currentPage < minPage) minPage = currentPage;
>+		if(currentPage > maxPage) maxPage = currentPage;
>+        }
> 	
> 	PSOutputDev *psOut = new PSOutputDev(outputToQIODevice, dev,
> 	                                     pstitlechar,
> 	                                     d->document->doc,
>-	                                     1,
>-	                                     d->document->doc->getNumPages(),
>+	                                     minPage,
>+	                                     maxPage,
> 	                                     (d->opts & PrintToEPS) ? psModeEPS : psModePS,
> 	                                     d->paperWidth,
> 	                                     d->paperHeight,

Actions: View | Splinter Review

Attachments on bug 84833: 107610 | 107611 | 108287 | 108296 | 108708

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.