Attachment 108289 Details for Bug 84944 – Add some debugging output to DRI2CanFlip v2

[patch] Add some debugging output to DRI2CanFlip v2

DRI2CanFlip-debug.diff (text/plain), 1.63 KB, created by Michel Dänzer on 2014-10-23 08:35:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2014-10-23 08:35:01 UTC

Size: 1.63 KB

patch

obsolete

>diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
>index 6459f11..632e5fa 100644
>--- a/hw/xfree86/dri2/dri2.c
>+++ b/hw/xfree86/dri2/dri2.c
>@@ -927,10 +927,23 @@ DRI2CanFlip(DrawablePtr pDraw)
> 
>     pWin = (WindowPtr) pDraw;
>     pWinPixmap = pScreen->GetWindowPixmap(pWin);
>-    if (pRootPixmap != pWinPixmap)
>+    if (pRootPixmap != pWinPixmap) {
>+        ErrorF("%s: Window pixmap != screen pixmap\n", __func__);
>         return FALSE;
>-    if (!RegionEqual(&pWin->clipList, &pRoot->winSize))
>+    }
>+    if (!RegionEqual(&pWin->clipList, &pRoot->winSize)) {
>+        BoxPtr extents;
>+
>+        ErrorF("%s: Window clipList doesn't match root window dimensions:\n",
>+               __func__);
>+        extents = RegionExtents(&pWin->clipList);
>+        ErrorF("Window clipList extents: (%d, %d)-(%d, %d)\n",
>+               extents->x1, extents->y1, extents->x2, extents->y2);
>+        extents = RegionExtents(&pRoot->winSize);
>+        ErrorF("Root window extents:     (%d, %d)-(%d, %d)\n",
>+               extents->x1, extents->y1, extents->x2, extents->y2);
>         return FALSE;
>+    }
> 
>     /* Does the window match the pixmap exactly? */
>     if (pDraw->x != 0 || pDraw->y != 0 ||
>@@ -938,8 +951,11 @@ DRI2CanFlip(DrawablePtr pDraw)
>         pDraw->x != pWinPixmap->screen_x || pDraw->y != pWinPixmap->screen_y ||
> #endif
>         pDraw->width != pWinPixmap->drawable.width ||
>-        pDraw->height != pWinPixmap->drawable.height)
>+        pDraw->height != pWinPixmap->drawable.height) {
>+        ErrorF("%s: Window pixmap dimensions don't match window dimensions\n",
>+               __func__);
>         return FALSE;
>+    }
> 
>     return TRUE;
> }

Actions: View | Splinter Review

Attachments on bug 84944: 107747 | 107748 | 108227 | 108267 | 108289

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.