Attachment 108863 Details for Bug 78770 – work-in-progress fix

[patch] work-in-progress fix

0001-wip-i965-Fix-segfault-in-WebGL-Conformance.patch (text/plain), 1.31 KB, created by Chad Versace on 2014-11-03 21:01:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chad Versace

Created: 2014-11-03 21:01:24 UTC

Size: 1.31 KB

patch

obsolete

>From 463cc35a43e54dc634fef73bce799f6244bee426 Mon Sep 17 00:00:00 2001
>From: Chad Versace <chad@kiwitree.net>
>Date: Mon, 3 Nov 2014 10:29:20 -0800
>Subject: [PATCH] wip! i965: Fix segfault in WebGL Conformance
>
>TODO: Write a proper fix.
>Prevent WebGL Conformance test texture-size-limit from segfaulting on Chrome.
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=78770
>---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
>index 59700ed..229485c 100644
>--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
>+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
>@@ -1664,7 +1664,13 @@ intel_miptree_map_gtt(struct brw_context *brw,
>       y += image_y;
> 
>       map->stride = mt->region->pitch;
>-      map->ptr = base + y * map->stride + x * mt->cpp;
>+
>+      /* TODO(chadv): Fix this correctly
>+       *
>+       * Prevent WebGL Conformance test texture-size-limit from segfaulting on Chrome.
>+       * See [https://bugs.freedesktop.org/show_bug.cgi?id=78770].
>+       */
>+      map->ptr = base + (intptr_t) y * (intptr_t) map->stride + (intptr_t) x * (intptr_t) mt->cpp;
>    }
> 
>    DBG("%s: %d,%d %dx%d from mt %p (%s) %d,%d = %p/%d\n", __FUNCTION__,
>-- 
>2.1.2.1.g5433a3e
>

Actions: View | Splinter Review

Attachments on bug 78770: 100086 | 108737 | 108863 | 108978 | 108983 | 109012 | 109076 | 109262

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.