Attachment 109218 Details for Bug 86063 – write correct size in trailer dict

[patch] write correct size in trailer dict

86063.patch (text/plain), 1.58 KB, created by Thomas Freitag on 2014-11-10 12:56:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Freitag

Created: 2014-11-10 12:56:40 UTC

Size: 1.58 KB

patch

obsolete

>diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
>index 8fd5e18..3218b33 100644
>--- a/poppler/PDFDoc.cc
>+++ b/poppler/PDFDoc.cc
>@@ -709,7 +709,7 @@ int PDFDoc::savePageAs(GooString *name, int pageNo)
>     annotsObj.free();
>   }
>   yRef->markUnencrypted();
>-  Guint objectsCount = writePageObjects(outStr, yRef, 0);
>+  writePageObjects(outStr, yRef, 0);
> 
>   yRef->add(rootNum,0,outStr->getPos(),gTrue);
>   outStr->printf("%d 0 obj\n", rootNum);
>@@ -730,7 +730,6 @@ int PDFDoc::savePageAs(GooString *name, int pageNo)
>   catObj.free();
>   pagesObj.free();
>   outStr->printf(">>\nendobj\n");
>-  objectsCount++;
> 
>   yRef->add(rootNum + 1,0,outStr->getPos(),gTrue);
>   outStr->printf("%d 0 obj\n", rootNum + 1);
>@@ -742,7 +741,6 @@ int PDFDoc::savePageAs(GooString *name, int pageNo)
>   }
>   outStr->printf(">>\n");
>   outStr->printf("endobj\n");
>-  objectsCount++;
> 
>   yRef->add(rootNum + 2,0,outStr->getPos(),gTrue);
>   outStr->printf("%d 0 obj\n", rootNum + 2);
>@@ -760,14 +758,13 @@ int PDFDoc::savePageAs(GooString *name, int pageNo)
>     value.free();
>   }
>   outStr->printf(" >>\nendobj\n");
>-  objectsCount++;
>   page.free();
> 
>   Goffset uxrefOffset = outStr->getPos();
>   Ref ref;
>   ref.num = rootNum;
>   ref.gen = 0;
>-  Dict *trailerDict = createTrailerDict(objectsCount, gFalse, 0, &ref, getXRef(),
>+  Dict *trailerDict = createTrailerDict(rootNum + 3, gFalse, 0, &ref, getXRef(),
>                                         name->getCString(), uxrefOffset);
>   writeXRefTableTrailer(trailerDict, yRef, gFalse /* do not write unnecessary entries */,
>                         uxrefOffset, outStr, getXRef());

Actions: View | Splinter Review

Attachments on bug 86063: 109153 | 109154 | 109155 | 109156 | 109218

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.