Attachment 109674 Details for Bug 86431 – Log to syslog when auth_timeout drops an incomplete connection

[patch] Log to syslog when auth_timeout drops an incomplete connection

0001-Log-to-syslog-when-auth_timeout-drops-an-incomplete-.patch (text/plain), 1.35 KB, created by Simon McVittie on 2014-11-18 15:01:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-11-18 15:01:12 UTC

Size: 1.35 KB

patch

obsolete

>From c43eac42e541d086f818e2323ab1db8c12435ec6 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 18 Nov 2014 12:01:44 +0000
>Subject: [PATCH] Log to syslog when auth_timeout drops an incomplete
> connection
>
>This is a symptom of either a denial of service attack, or a
>serious performance problem. Either way, sysadmins should know.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=86431
>---
> bus/connection.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/bus/connection.c b/bus/connection.c
>index 519122c..7107434 100644
>--- a/bus/connection.c
>+++ b/bus/connection.c
>@@ -860,6 +860,14 @@ bus_connections_expire_incomplete (BusConnections *connections)
> 
>           if (elapsed >= (double) auth_timeout)
>             {
>+              /* Unfortunately, we can't identify the connection: it doesn't
>+               * have a unique name yet, we don't know its uid/pid yet,
>+               * and so on. */
>+              bus_context_log (connections->context, DBUS_SYSTEM_LOG_INFO,
>+                  "Connection has not authenticated soon enough, closing it "
>+                  "(auth_timeout=%dms, elapsed: %.0fms)",
>+                  auth_timeout, elapsed);
>+
>               _dbus_verbose ("Timing out authentication for connection %p\n", connection);
>               dbus_connection_close (connection);
>             }
>-- 
>2.1.3
>

Actions: View | Splinter Review

Attachments on bug 86431: 109674 | 109677 | 109681 | 109745

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.