Attachment 109685 Details for Bug 86442 – Log max_pending_service_starts (aka max_pending_activations) when exceeded

[patch] Log max_pending_service_starts (aka max_pending_activations) when exceeded

0007-Log-max_pending_service_starts-aka-max_pending_activ.patch (text/plain), 1.46 KB, created by Simon McVittie on 2014-11-18 19:22:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-11-18 19:22:49 UTC

Size: 1.46 KB

patch

obsolete

>From 8c3c8bab7c50a07ebaa625d0b3ace2a650e60342 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 18 Nov 2014 12:35:28 +0000
>Subject: [PATCH 07/11] Log max_pending_service_starts (aka
> max_pending_activations) when exceeded
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=86442
>---
> bus/activation.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/bus/activation.c b/bus/activation.c
>index 4a3bf4a..b903b1c 100644
>--- a/bus/activation.c
>+++ b/bus/activation.c
>@@ -1740,15 +1740,19 @@ bus_activation_activate_service (BusActivation  *activation,
>   dbus_bool_t retval;
>   dbus_bool_t was_pending_activation;
>   DBusString command;
>+  int limit;
> 
>   _DBUS_ASSERT_ERROR_IS_CLEAR (error);
> 
>-  if (activation->n_pending_activations >=
>-      bus_context_get_max_pending_activations (activation->context))
>+  limit = bus_context_get_max_pending_activations (activation->context);
>+
>+  if (activation->n_pending_activations >= limit)
>     {
>       dbus_set_error (error, DBUS_ERROR_LIMITS_EXCEEDED,
>-                      "The maximum number of pending activations has been reached, activation of %s failed",
>-                      service_name);
>+                      "The maximum number of pending activations has been "
>+                      "reached, activation of %s failed "
>+                      "(max_pending_service_starts=%d)",
>+                      service_name, limit);
>       return FALSE;
>     }
> 
>-- 
>2.1.3
>

Actions: View | Splinter Review

Attachments on bug 86442: 109682 | 109683 | 109684 | 109685 | 109686 | 109687 | 109688 | 109689 | 124822 | 124823 | 124824 | 124825 | 124826 | 124827 | 124828 | 124829 | 124830 | 124831 | 124832 | 124833 | 124834 | 124838

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.