Attachment 111983 Details for Bug 88191 – s/readl/wmb/

[patch] s/readl/wmb/

0001-bug88191.patch (text/plain), 1.37 KB, created by Chris Wilson on 2015-01-08 23:22:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2015-01-08 23:22:07 UTC

Size: 1.37 KB

patch

obsolete

>From d39d7c1ccb9aa4aa47ae5a31fbf7dcd24644a5b7 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Thu, 8 Jan 2015 23:21:45 +0000
>Subject: [PATCH] bug88191
>
>---
> drivers/char/agp/intel-gtt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
>index 778e8cf..5fc47e3 100644
>--- a/drivers/char/agp/intel-gtt.c
>+++ b/drivers/char/agp/intel-gtt.c
>@@ -225,7 +225,7 @@ static int i810_insert_dcache_entries(struct agp_memory *mem, off_t pg_start,
> 		intel_private.driver->write_entry(addr,
> 						  i, type);
> 	}
>-	readl(intel_private.gtt+i-1);
>+	wmb();
> 
> 	return 0;
> }
>@@ -865,7 +865,7 @@ void intel_gtt_insert_sg_entries(struct sg_table *st,
> 			j++;
> 		}
> 	}
>-	readl(intel_private.gtt+j-1);
>+	wmb();
> }
> EXPORT_SYMBOL(intel_gtt_insert_sg_entries);
> 
>@@ -882,7 +882,7 @@ static void intel_gtt_insert_pages(unsigned int first_entry,
> 		intel_private.driver->write_entry(addr,
> 						  j, flags);
> 	}
>-	readl(intel_private.gtt+j-1);
>+	wmb();
> }
> 
> static int intel_fake_agp_insert_entries(struct agp_memory *mem,
>@@ -945,7 +945,7 @@ void intel_gtt_clear_range(unsigned int first_entry, unsigned int num_entries)
> 		intel_private.driver->write_entry(intel_private.scratch_page_dma,
> 						  i, 0);
> 	}
>-	readl(intel_private.gtt+i-1);
>+	wmb();
> }
> EXPORT_SYMBOL(intel_gtt_clear_range);
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 88191: 111939 | 111983 | 112001

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.