Attachment 112694 Details for Bug 88715 – check for incoming MT slot indices

[patch] check for incoming MT slot indices

0001-Check-for-incoming-MT-slot-indices-exceeding-the-all.patch (text/plain), 1.13 KB, created by provisorisch on 2015-01-23 01:53:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: provisorisch

Created: 2015-01-23 01:53:46 UTC

Size: 1.13 KB

patch

obsolete

>From 147a4df6caacc06e8de114b160053ce7d7d9975b Mon Sep 17 00:00:00 2001
>From: Tobias Himmer <provisorisch@online.de>
>Date: Fri, 23 Jan 2015 02:13:17 +0100
>Subject: [PATCH evdev] Check for incoming MT slot indices exceeding the
> allocated number of slots.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=88715
>
>Signed-off-by: Tobias Himmer <provisorisch@online.de>
>---
> src/evdev.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/src/evdev.c b/src/evdev.c
>index 2d99f07..3c00e69 100644
>--- a/src/evdev.c
>+++ b/src/evdev.c
>@@ -733,6 +733,14 @@ EvdevProcessTouchEvent(InputInfoPtr pInfo, struct input_event *ev)
> 
>     if (ev->code == ABS_MT_SLOT) {
>         EvdevProcessTouch(pInfo);
>+        if (ev->value >= num_slots(pEvdev) ) {
>+            LogMessageVerbSigSafe(X_WARNING, 0,
>+                                  "%s: Slot index %d out of bounds (max %d), touch events may be incorrect.\n",
>+                                  pInfo->name,
>+                                  ev->value,
>+                                  num_slots(pEvdev)-1);
>+            return;
>+        }
>         pEvdev->cur_slot = ev->value;
>     } else
>     {
>-- 
>2.2.1
>

Actions: View | Splinter Review

Attachments on bug 88715: 112673 | 112674 | 112694

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.