Attachment 112854 Details for Bug 88812 – [PATCH 2/2] Improve diagnostics when UpdateActivationEnvironment calls are rejected

[patch] [PATCH 2/2] Improve diagnostics when UpdateActivationEnvironment calls are rejected

0002-Improve-diagnostics-when-UpdateActivationEnvironment.patch (text/plain), 1.80 KB, created by Simon McVittie on 2015-01-26 21:14:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-01-26 21:14:41 UTC

Size: 1.80 KB

patch

obsolete

>From 26782eb1e034c22e333143de44f2d382a0daa664 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 26 Jan 2015 21:10:35 +0000
>Subject: [PATCH 2/2] Improve diagnostics when UpdateActivationEnvironment
> calls are rejected
>
>---
> bus/driver.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/bus/driver.c b/bus/driver.c
>index 6048d24..3662001 100644
>--- a/bus/driver.c
>+++ b/bus/driver.c
>@@ -927,7 +927,9 @@ bus_driver_handle_update_activation_environment (DBusConnection *connection,
>           bus_context_log (bus_transaction_get_context (transaction),
>               DBUS_SYSTEM_LOG_SECURITY,
>               "rejected attempt to call UpdateActivationEnvironment by "
>-              "unknown uid");
>+              "connection %s (%s) with unknown uid",
>+              nonnull (bus_connection_get_name (connection), "(inactive)"),
>+              bus_connection_get_loginfo (connection));
>           dbus_set_error (error, DBUS_ERROR_ACCESS_DENIED,
>               "rejected attempt to call UpdateActivationEnvironment by "
>               "unknown uid");
>@@ -941,7 +943,10 @@ bus_driver_handle_update_activation_environment (DBusConnection *connection,
>         {
>           bus_context_log (bus_transaction_get_context (transaction),
>               DBUS_SYSTEM_LOG_SECURITY,
>-              "rejected attempt to call UpdateActivationEnvironment by uid %lu",
>+              "rejected attempt to call UpdateActivationEnvironment by "
>+              "connection %s (%s) with uid %lu",
>+              nonnull (bus_connection_get_name (connection), "(inactive)"),
>+              bus_connection_get_loginfo (connection),
>               uid);
>           dbus_set_error (error, DBUS_ERROR_ACCESS_DENIED,
>               "rejected attempt to call UpdateActivationEnvironment");
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 88812: 112853 | 112854

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.