Attachment 113060 Details for Bug 88810 – [08/11] bus: put the printf attribute in the header where it will do more good

[patch] [08/11] bus: put the printf attribute in the header where it will do more good

0008-bus-put-the-printf-attribute-in-the-header-where-it-.patch (text/plain), 1.81 KB, created by Simon McVittie on 2015-02-02 19:23:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-02-02 19:23:10 UTC

Size: 1.81 KB

patch

obsolete

>From 24819524a77db6f4a00621d3a4ede6167a218320 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 2 Feb 2015 17:29:43 +0000
>Subject: [PATCH 08/12] bus: put the printf attribute in the header where it
> will do more good
>
>Now we can actually notice incorrect format strings in other
>translation units.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88810
>---
> bus/bus.c | 3 ---
> bus/bus.h | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/bus/bus.c b/bus/bus.c
>index f51ee99..84e6a1f 100644
>--- a/bus/bus.c
>+++ b/bus/bus.c
>@@ -1325,9 +1325,6 @@ bus_context_get_initial_fd_limit (BusContext *context)
> }
> 
> void
>-bus_context_log (BusContext *context, DBusSystemLogSeverity severity, const char *msg, ...) _DBUS_GNUC_PRINTF (3, 4);
>-
>-void
> bus_context_log (BusContext *context, DBusSystemLogSeverity severity, const char *msg, ...)
> {
>   va_list args;
>diff --git a/bus/bus.h b/bus/bus.h
>index dac6ea5..d05c80f 100644
>--- a/bus/bus.h
>+++ b/bus/bus.h
>@@ -120,7 +120,7 @@ DBusRLimit *      bus_context_get_initial_fd_limit               (BusContext
> void              bus_context_log                                (BusContext       *context,
>                                                                   DBusSystemLogSeverity severity,
>                                                                   const char       *msg,
>-                                                                  ...);
>+                                                                  ...) _DBUS_GNUC_PRINTF (3, 4);
> dbus_bool_t       bus_context_check_security_policy              (BusContext       *context,
>                                                                   BusTransaction   *transaction,
>                                                                   DBusConnection   *sender,
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 88810: 112842 | 112843 | 112844 | 112845 | 112846 | 112847 | 112855 | 113053 | 113054 | 113055 | 113056 | 113057 | 113058 | 113059 | 113060 | 113061 | 113062 | 113063

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.